Complete port of PR 521 to netfx#2964
Merged
cheenamalhotra merged 1 commit intodotnet:mainfrom Nov 7, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2964 +/- ##
==========================================
- Coverage 72.31% 72.30% -0.02%
==========================================
Files 288 288
Lines 59660 59660
==========================================
- Hits 43145 43138 -7
- Misses 16515 16522 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
benrr101
approved these changes
Nov 4, 2024
Contributor
benrr101
left a comment
benrr101
left a comment
There was a problem hiding this comment.
Yep, looks like those two lines weren't picked up in the backport. Kinda disconcerting that it didn't break anything 🤔
Thanks for finding and making the fix!
mdaigle
approved these changes
Nov 7, 2024
cheenamalhotra
approved these changes
Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #521 was originally made to .NET Core, and cross-ported to .NET Framework by PR #1443. There were two lines missing from this PR, in GetValues and GetSqlValues. This PR completes that work.