Skip to content

Conversation

@paulmedynski
Copy link
Contributor

Description

  • Bumped oudated dependencies to their latest versions depending on target framework.

Issues

Testing

  • Existing CI will suffice.

- Bumped oudated dependencies to their latest versions depending on target framework.
@paulmedynski paulmedynski added this to the 7.0-preview2 milestone Sep 26, 2025
@paulmedynski paulmedynski requested a review from a team as a code owner September 26, 2025 15:39
Copilot AI review requested due to automatic review settings September 26, 2025 15:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates outdated dependencies to their latest versions for different target frameworks, addressing issue #3621. The changes ensure the SqlClient library uses up-to-date versions of Azure, Microsoft, and System packages while maintaining compatibility across different .NET target frameworks.

Key changes include:

  • Updated Azure SDK packages (Azure.Core, Azure.Identity, Azure.Security.KeyVault.Keys) to latest versions
  • Upgraded Microsoft.IdentityModel packages from 7.x to 8.x series
  • Updated various System packages and test dependencies
  • Added pragma warnings to suppress obsolete member warnings for MSAL.NET methods

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tools/specs/add-ons/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.nuspec Updates Azure.Core and Azure.Security.KeyVault.Keys dependencies for both net462 and net8.0 target frameworks
tools/specs/Microsoft.Data.SqlClient.nuspec Updates all dependency versions across net462, net8.0, net9.0, and netstandard2.0 target frameworks
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectivityTests/AADConnectionTest.cs Adds pragma warnings to suppress obsolete warnings for AcquireTokenByUsernamePassword method
src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs Adds pragma warnings to suppress obsolete warnings for AcquireTokenByUsernamePassword method
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ActiveDirectoryAuthenticationProvider.cs Adds pragma warnings to suppress obsolete warnings for AcquireTokenByUsernamePassword and SharedTokenCacheUsername
src/Directory.Packages.props Central package version management file updated with all new dependency versions and includes explanatory comment for Microsoft.Extensions.Hosting version constraint

Copy link
Contributor Author

@paulmedynski paulmedynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commentary.

@codecov
Copy link

codecov bot commented Sep 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.96%. Comparing base (d244be2) to head (9c6ba1f).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3638      +/-   ##
==========================================
+ Coverage   66.43%   66.96%   +0.52%     
==========================================
  Files         271      277       +6     
  Lines       60277    60594     +317     
==========================================
+ Hits        40048    40576     +528     
+ Misses      20229    20018     -211     
Flag Coverage Δ
addons 90.82% <ø> (?)
netcore 71.11% <100.00%> (+1.22%) ⬆️
netfx 68.19% <100.00%> (-0.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mdaigle mdaigle self-assigned this Sep 29, 2025
@paulmedynski paulmedynski merged commit 02c9c21 into main Sep 30, 2025
252 checks passed
@paulmedynski paulmedynski deleted the dev/paul/bump-deps branch September 30, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Azure.Identity to get rid of unnecessary System.Memory for .NET 8+

5 participants