Fix | MARS header errors when MakeReadAsyncBlocking = false#922
Merged
Conversation
cheenamalhotra
approved these changes
Feb 23, 2021
JRahnama
approved these changes
Feb 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #85 when MakeReadAsyncBlocking = false.
What we found was that an async continuation task would sometimes run right after cancel. The State snapshot replay logic would change _hasOpenResult without incrementing/decrementing the counter so it would get out of sync and decrement the counter with no corresponding increment. This fixes it so that we can use MakeReadAsyncBlocking = false without MARS header errors.