Upped timeout and added logs for downloading and publishing operation#7351
Merged
epananth merged 8 commits intodotnet:mainfrom May 6, 2021
Merged
Upped timeout and added logs for downloading and publishing operation#7351epananth merged 8 commits intodotnet:mainfrom
epananth merged 8 commits intodotnet:mainfrom
Conversation
ghost
reviewed
May 6, 2021
src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs
Outdated
Show resolved
Hide resolved
ghost
approved these changes
May 6, 2021
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Do you have any example builds? Just to see how readable the logs are with these changes
Member
Author
|
Running a build now https://dnceng.visualstudio.com/internal/_build/results?buildId=1126019&view=results, I will post the log here after this completes |
Member
Author
|
|
Member
Author
|
|
|
I think it would be nice to not lose the decimals in the seconds. |
Member
Author
|
Yeah all the downloads were 0 seconds :D , made sure we have decimals for time taken |
ghost
approved these changes
May 6, 2021
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To double check: