Skip to content

Log a warning when anyone uses V2 publishing from Arcade 6.0+ #7415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MattGal merged 3 commits into from
May 24, 2021
Merged

Log a warning when anyone uses V2 publishing from Arcade 6.0+ #7415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c051b7
Log a warning when anyone uses V2 publishing from Arcade 6.0+ (main a…
MattGal May 20, 2021
aaca9d0
error --> warning
MattGal May 24, 2021
ad60d19
re-disable android tests, since I can't force merge any more.
MattGal May 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,20 +130,22 @@ stages:
env:
SYSTEM_ACCESSTOKEN: $(System.AccessToken)
HelixAccessToken: ''
- powershell: eng\common\build.ps1
-configuration $(_BuildConfig)
-prepareMachine
-ci
-restore
-test
-projects $(Build.SourcesDirectory)\tests\UnitTests.XHarness.Android.WindowsQueues.proj
/bl:$(Build.SourcesDirectory)\artifacts\log\$(_BuildConfig)\Helix.XHarness.Android.WindowsQueues.binlog
/p:RestoreUsingNuGetTargets=false
/p:XharnessTestARM64_V8A=true
displayName: XHarness Android Helix Testing (Windows)
env:
SYSTEM_ACCESSTOKEN: $(System.AccessToken)
HelixAccessToken: ''
# We don't have enough hardware to run these tests on Arcade PR given the Arcade XHarness SDK changes infrequently. (https://github.com/dotnet/core-eng/issues/12238)
# Until the above issue is resolved, if you are editing the Xharness SDK's Windows side, please exercise this manually. Contact dnceng for assistance.
# - powershell: eng\common\build.ps1
# -configuration $(_BuildConfig)
# -prepareMachine
# -ci
# -restore
# -test
# -projects $(Build.SourcesDirectory)\tests\UnitTests.XHarness.Android.WindowsQueues.proj
# /bl:$(Build.SourcesDirectory)\artifacts\log\$(_BuildConfig)\Helix.XHarness.Android.WindowsQueues.binlog
# /p:RestoreUsingNuGetTargets=false
# /p:XharnessTestARM64_V8A=true
# displayName: XHarness Android Helix Testing (Windows)
# env:
# SYSTEM_ACCESSTOKEN: $(System.AccessToken)
# HelixAccessToken: ''
- job: Linux
timeoutInMinutes: 90
container: LinuxContainer
Expand Down
6 changes: 6 additions & 0 deletions eng/common/templates/post-build/channels/generic-internal-channel.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ stages:
pool:
vmImage: 'windows-2019'
steps:
- script: echo "##vso[task.logissue type=warning]Going forward, v2 Arcade publishing is no longer supported. Please read https://github.com/dotnet/arcade/blob/main/Documentation/CorePackages/Publishing.md for details, then contact dnceng if you have further questions."
displayName: Warn about v2 Arcade Publishing Usage

# This is necessary whenever we want to publish/restore to an AzDO private feed
- task: NuGetAuthenticate@0
displayName: 'Authenticate to AzDO Feeds'
Expand Down Expand Up @@ -110,6 +113,9 @@ stages:
pool:
vmImage: 'windows-2019'
steps:
- script: echo "##vso[task.logissue type=warning]Going forward, v2 Arcade publishing is no longer supported. Please read https://github.com/dotnet/arcade/blob/main/Documentation/CorePackages/Publishing.md for details, then contact dnceng if you have further questions."
displayName: Warn about v2 Arcade Publishing Usage

- task: DownloadBuildArtifacts@0
displayName: Download Build Assets
continueOnError: true
Expand Down
6 changes: 6 additions & 0 deletions eng/common/templates/post-build/channels/generic-public-channel.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ stages:
pool:
vmImage: 'windows-2019'
steps:
- script: echo "##vso[task.logissue type=warning]Going forward, v2 Arcade publishing is no longer supported. Please read https://github.com/dotnet/arcade/blob/main/Documentation/CorePackages/Publishing.md for details, then contact dnceng if you have further questions."
displayName: Warn about v2 Arcade Publishing Usage

- task: DownloadBuildArtifacts@0
displayName: Download Build Assets
continueOnError: true
Expand Down Expand Up @@ -109,6 +112,9 @@ stages:
pool:
vmImage: 'windows-2019'
steps:
- script: echo "##vso[task.logissue type=warning]Going forward, v2 Arcade publishing is no longer supported. Please read https://github.com/dotnet/arcade/blob/main/Documentation/CorePackages/Publishing.md for details, then contact dnceng if you have further questions."
displayName: Warn about v2 Arcade Publishing Usage

- task: DownloadBuildArtifacts@0
displayName: Download Build Assets
continueOnError: true
Expand Down