Force safe version of System.Text.Encodings.Web, even in test projects#7833
Merged
garath merged 4 commits intodotnet:mainfrom Sep 8, 2021
Merged
Force safe version of System.Text.Encodings.Web, even in test projects#7833garath merged 4 commits intodotnet:mainfrom
garath merged 4 commits intodotnet:mainfrom
Conversation
ghost
approved these changes
Sep 2, 2021
src/Microsoft.DotNet.Build.Tasks.Feed.Tests/Microsoft.DotNet.Build.Tasks.Feed.Tests.csproj
Show resolved
Hide resolved
…s version is needed to keep net47 support. This reverts commit 806864e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minimal update to System.Text.Encodings.Web to avoid a vulnerable version. This change was already made in the primary project in #7685. This just does the same in the test project. All unit tests pass on my machine.