Merged
Conversation
added 2 commits
September 21, 2021 12:57
This code is already dead inside Helix... we no longer read the events this reporter is sending, so it's just spending a bunch of time to send dead events. I'm removing the code and having it send an obselete warning.
alexperovich
approved these changes
Sep 21, 2021
premun
reviewed
Sep 22, 2021
Member
premun
left a comment
premun
left a comment
There was a problem hiding this comment.
I found many more references of EnableXUnitReporter in this repo. Can you remove all?
Contributor
Author
|
@premun, sure... I'll see what I can find... why is one flag documented in multiple places... but I'll find them. :-) |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code is already dead inside Helix... we no longer read the events this
reporter is sending, so it's just spending a bunch of time to send dead
events. I'm removing the code and having it send an obselete warning.
It also causes a workitem to be non-idepotent, because it uploads a file to a fixed
URI, and if a retry (infra, test, or otherwise) happens, the second upload crashes,
causing the workitem to fail.