Update Microsoft.Net.Sdk.WorkloadManifestReader to RTM version#8054
Merged
MattGal merged 1 commit intodotnet:mainfrom Oct 18, 2021
Merged
Update Microsoft.Net.Sdk.WorkloadManifestReader to RTM version#8054MattGal merged 1 commit intodotnet:mainfrom
MattGal merged 1 commit intodotnet:mainfrom
Conversation
ghost
approved these changes
Oct 18, 2021
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
I have no idea what any of these versions are or what this component is used for. The update seems fine though.
Member
Author
|
I've verified via debugging w/ the tests that the changes give the results I'd expect; there is some expectation that this may no longer be in use since we'd expect this update to have already occurred if so, but we can address that in the future if we have to. |
Member
|
If there were changes in the behavior it could impact the generated workload packs/manifests for VS. There's no way to tell until you actually do a full build of the workloads, e.g. EMSDK or runtime (for the mono workloads), but this should be okay |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7880 - there were a couple small breaking changes that required minor updates. This change passes all tests but it is possible further breaking changes may be found later.
To double check: