Add back the quotes to sdl configuration#8074
Merged
michellemcdaniel merged 1 commit intodotnet:mainfrom Oct 21, 2021
Merged
Conversation
When the code for running the configure step in sdl validation was moved, the quotes were removed from the tool args. This prevents us from upgrading the version of guardian, because newer versions of guardian get confused by the triangle brackets. This change adds back the quotes around each tool arg.
michellemcdaniel
requested review from
MattGal,
dagood,
epananth and
jonfortescue
jonfortescue
approved these changes
Oct 20, 2021
Member
I'm curious which one--I was on 0.79.1 with this code. Thanks for the heads up and fix. |
dagood
approved these changes
Oct 21, 2021
Contributor
Author
I was running 0.100.0 locally and it was throwing up errors. Might have been a local issue, but doesn’t hurt to have the quotes |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the code for running the configure step in sdl validation was moved, the quotes were removed from the tool args. This prevents us from upgrading the version of guardian, because newer versions of guardian get confused by the triangle brackets. This change adds back the quotes around each tool arg.
To double check: