Improved Kubernetes publisher labels#10208
Merged
davidfowl merged 5 commits intodotnet:mainfrom Jul 12, 2025
Merged
Conversation
…n more with Kubernetes recommendations.
davidfowl
reviewed
Jul 2, 2025
tests/Aspire.Hosting.Kubernetes.Tests/KubernetesPublisherTests.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Jul 2, 2025
Co-authored-by: David Fowler <davidfowl@gmail.com>
…into hewe/fix-labels
Contributor
Author
|
@davidfowl Is there anything else I should change to get this in? |
davidfowl
approved these changes
Jul 9, 2025
Member
|
Just FYI, this won't be in 9.4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add labels to all generated resources, updated default labels to align more with Kubernetes recommendations.
https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/#labels
Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate