Add dashboard telemetry to interaction service#10272
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds telemetry identifiers and instrumentation across dashboard pages, controls, and interactions to centralize component telemetry.
- Introduces
TelemetryComponentIdswith named constants for pages and controls - Replaces hard-coded
nameof(...)strings withTelemetryComponentIdsreferences in page/control components - Extends
InteractionsProviderto generate and disposeComponentTelemetryContextfor dialogs and message bars
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Aspire.Dashboard/Telemetry/TelemetryComponentIds.cs | New static class defining component telemetry identifiers |
| src/Aspire.Dashboard/Components/Pages/*.razor.cs | Updated TelemetryContext initialization to use constants |
| src/Aspire.Dashboard/Components/Controls/*.razor.cs | Updated control telemetry context to use constants |
| src/Aspire.Dashboard/Components/Interactions/InteractionsProvider.cs | Added telemetry context creation/disposal for interactions |
Comments suppressed due to low confidence (1)
src/Aspire.Dashboard/Telemetry/TelemetryComponentIds.cs:6
- No unit tests were added for the new
TelemetryComponentIdsconstants or the telemetry initialization logic inInteractionsProvider. Consider adding tests to validate constant values and that telemetry contexts are created, initialized, and disposed as expected.
public static class TelemetryComponentIds
src/Aspire.Dashboard/Components/Interactions/InteractionsProvider.cs
Outdated
Show resolved
Hide resolved
adamint
approved these changes
Jul 9, 2025
Member
|
/backport to release/9.4 |
Contributor
|
Started backporting to release/9.4: https://github.com/dotnet/aspire/actions/runs/16207876810 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TelemetryComponentIdswith constants for component telemetry IDsChecklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate