Remove SqlServerScriptProvisioningResource

[eerhardt]

Description

This workaround is no longer necessary now that the issues in the Azure.Provisioning libraries are resolved.

Checklist

• Is this feature complete?
  • Yes. Ready to ship.
• Are you including unit tests for the changes and scenario tests if relevant?
  • Yes
• Did you add public API?
  • No
• Does the change make any security assumptions or guarantees?
  • No
• Does the change require an update in our Aspire docs?
  • No

[Copilot]

Pull Request Overview

This PR removes the custom SqlServerScriptProvisioningResource workaround and directly uses AzurePowerShellScript now that the underlying Azure.Provisioning issue is resolved.

• Deleted the entire SqlServerScriptProvisioningResource class and its supporting logic.
• Updated AzureSqlServerResource to instantiate AzurePowerShellScript and set the retention interval inline.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/Aspire.Hosting.Azure.Sql/SqlServerScriptProvisioningResource.cs	Removed obsolete workaround class entirely.
src/Aspire.Hosting.Azure.Sql/AzureSqlServerResource.cs	Replaced custom resource instantiation with AzurePowerShellScript and added RetentionInterval.

Comments suppressed due to low confidence (2)

src/Aspire.Hosting.Azure.Sql/AzureSqlServerResource.cs:159

• Double-check whether AzurePowerShellScript still sets the kind property to "AzurePowerShell" by default as the custom class did. If not, you may need to explicitly set scriptResource.Kind = "AzurePowerShell" to preserve the same behavior.

            var scriptResource = new AzurePowerShellScript($"script_{uniqueScriptIdentifier}")

src/Aspire.Hosting.Azure.Sql/AzureSqlServerResource.cs:162

• Ensure that existing tests referencing SqlServerScriptProvisioningResource are updated to cover the new AzurePowerShellScript behavior, and consider adding or adjusting tests to verify that RetentionInterval is correctly applied.

                RetentionInterval = TimeSpan.FromHours(1),

[davidfowl]

LGTM