Do not match pipe as port separator#10884
Merged
davidfowl merged 1 commit intodotnet:mainfrom Aug 8, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a regex pattern in the ConnectionStringParser that was incorrectly matching pipe characters ('|') as valid port separators. The change ensures only colon (':') and comma (',') are recognized as valid separators between host and port in connection strings.
Key Changes
- Updated the regex pattern to remove pipe character from the character class
- Changed
[:|,]to[:,]to match only colon or comma separators
Member
|
Good catch |
davidfowl
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Using grep.app I noticed that a slightly incorrect regex was introduced in #10340 to match "host and port".
[:|,]matches any of the characters:, '|' or,, where the updated regex[:,]only matches:or,.Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate