[release/9.4] serve blazor.web.js from wwwroot#10990
Merged
davidfowl merged 1 commit intorelease/9.4from Aug 19, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR transitions the Aspire Dashboard's blazor.web.js file from being served as an embedded resource to being served from the wwwroot directory as a static file. This change simplifies the file serving mechanism by removing custom endpoint mapping and embedded file provider infrastructure.
- Removes custom endpoint mapping for blazor.web.js that used embedded file providers
- Updates the script reference in App.razor to use the standard framework path
- Removes embedded resource configuration and related package dependencies
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Aspire.Dashboard/DashboardWebApplication.cs | Removes call to MapDashboardBlazor() method |
| src/Aspire.Dashboard/DashboardEndpointsBuilder.cs | Removes entire MapDashboardBlazor() method and related imports |
| src/Aspire.Dashboard/Components/App.razor | Updates script src from custom path to standard framework path |
| src/Aspire.Dashboard/Aspire.Dashboard.csproj | Removes embedded resource configuration and file provider package reference |
| eng/Versions.props | Removes version property for embedded file provider package |
| Directory.Packages.props | Removes package version entry for embedded file provider |
adamint
approved these changes
Aug 18, 2025
davidfowl
approved these changes
Aug 19, 2025
This was referenced Sep 3, 2025
This was referenced Sep 15, 2025
Closed
Closed
Closed
Closed
whytem
pushed a commit
to whytem/aspire
that referenced
this pull request
Sep 16, 2025
…o serve it (dotnet#10990) Co-authored-by: Adam Ratzman <adam@adamratzman.com>
This was referenced Sep 17, 2025
Bump Microsoft.Extensions.ServiceDiscovery from 9.4.0 to 9.4.2
MartinWheelerDotNet/MyWhiskyShelf#107
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customer Impact
At least 3 people have reported seeing this error when running the dashboard:
Unsure exactly what is causing the failure. Only some people are impacted. All reports are from MS folks?
We're fixing by switching to server the file from disk instead of using embedded file.
Testing
Manual. I launched the dashboard with the change to check the script file is available and the dashboard loads.
Risk
Low. Although it's critical that the dashboard loads this file, the delivery option (file on disk) is used for all other files. It's also easy to check whether it works or not.
Regression?
Yes. The dashboard worked consistently in 9.3, but in 9.4 there is this occasional error.