Update connection properties for non-Azure resources#12583
Merged
sebastienros merged 6 commits intomainfrom Nov 1, 2025
Merged
Update connection properties for non-Azure resources#12583sebastienros merged 6 commits intomainfrom
sebastienros merged 6 commits intomainfrom
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12583Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12583" |
a33209d to
c2cb88e
Compare
c2cb88e to
f501a23
Compare
davidfowl
approved these changes
Nov 1, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds comprehensive Connection Properties documentation sections to multiple Aspire hosting README files and implements URI connection properties for SQL Server and Oracle database resources. The changes improve documentation consistency across Aspire hosting integrations and enhance the resource API with standardized URI expressions.
Key Changes
- Added URI expressions (
UriExpressionproperties) to SQL Server and Oracle server/database resources to provide standardized connection URIs - Added comprehensive "Connection Properties" sections to 14 README files documenting available connection properties when using
WithReference - Fixed PostgreSQL JDBC connection string to include user and password query parameters
- Removed obsolete
.vscode/mcp.jsonMCP server configuration - Added a new agent configuration file (
.github/agents/connectionproperties.agent.md) documenting connection properties standards
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
src/Aspire.Hosting.SqlServer/SqlServerServerResource.cs |
Added UriExpression property, added CombineProperties helper method, and included Uri in connection properties |
src/Aspire.Hosting.SqlServer/SqlServerDatabaseResource.cs |
Added database-specific UriExpression property and included Uri in connection properties |
src/Aspire.Hosting.Oracle/OracleDatabaseServerResource.cs |
Added UriExpression property and included Uri in connection properties |
src/Aspire.Hosting.Oracle/OracleDatabaseResource.cs |
Added database-specific UriExpression property and included Uri in connection properties |
src/Aspire.Hosting.PostgreSQL/PostgresServerResource.cs |
Fixed JDBC connection string to include authentication parameters |
src/Aspire.Hosting.SqlServer/README.md |
Added "Connection Properties" section documenting server and database properties |
src/Aspire.Hosting.PostgreSQL/README.md |
Added "Connection Properties" section documenting server and database properties |
src/Aspire.Hosting.Oracle/README.md |
Added "Connection Properties" section documenting server and database properties |
src/Aspire.Hosting.Valkey/README.md |
Improved structure with "Getting started" section and added "Connection Properties" table |
src/Aspire.Hosting.Redis/README.md |
Added "Connection Properties" section documenting Redis connection properties |
src/Aspire.Hosting.Garnet/README.md |
Improved structure and added "Connection Properties" section |
src/Aspire.Hosting.RabbitMQ/README.md |
Added "Connection Properties" section documenting RabbitMQ server properties |
src/Aspire.Hosting.Seq/README.md |
Added "Connection Properties" section documenting Seq server properties |
src/Aspire.Hosting.Nats/README.md |
Added "Connection Properties" section documenting NATS server properties |
src/Aspire.Hosting.Kafka/README.md |
Added "Connection Properties" section documenting Kafka server properties |
src/Aspire.Hosting.MongoDB/README.md |
Added "Connection Properties" section documenting MongoDB server and database properties |
src/Aspire.Hosting.MySql/README.md |
Added "Connection Properties" section documenting MySQL server and database properties |
src/Aspire.Hosting.Milvus/README.md |
Added "Connection Properties" section documenting Milvus server and database properties |
src/Aspire.Hosting.Qdrant/README.md |
Added "Connection Properties" section documenting Qdrant server properties |
src/Aspire.Hosting.OpenAI/README.md |
Added "Connection Properties" section documenting OpenAI resource and model properties |
src/Aspire.Hosting.GitHub.Models/README.md |
Added "Connection Properties" section documenting GitHub Model properties |
.vscode/mcp.json |
Removed obsolete MCP server configuration |
.github/agents/connectionproperties.agent.md |
Added agent documentation defining connection properties implementation standards |
Member
Author
|
/backport to release/13.0 |
Contributor
|
Started backporting to release/13.0: https://github.com/dotnet/aspire/actions/runs/18992334804 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refines existing connection properties and docs.
Checklist
<remarks />and<code />elements on your triple slash comments?