Merged
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12592Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12592" |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates Docker base images in the WithDockerfile playground application from community images to Microsoft-provided container images for better security and support.
- Updated Go builder image from
golang:1.22-alpinetomcr.microsoft.com/oss/go/microsoft/golang:1.23 - Updated runtime base image from
alpine:latesttomcr.microsoft.com/cbl-mariner/base/core:2.0 - Changes applied consistently across both sync and async dynamic Dockerfile generation examples
Comments suppressed due to low confidence (1)
playground/withdockerfile/WithDockerfile.AppHost/Program.cs:11
- The default Go version parameter is still set to '1.22', but the dynamic Dockerfile generators now use golang:1.23. Consider updating this parameter default to '1.23' to maintain consistency across the codebase.
var goVersion = builder.AddParameter("goversion", "1.22");
davidfowl
approved these changes
Nov 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing up some supply chain warnings on internal builds that are generating warning noise.