Skip to content

Make app provisioning wait for role assignments and private endpoints #14483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: release/13.2
Choose a base branch
from
+63 −39
Draft

Make app provisioning wait for role assignments and private endpoints #14483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ecb0d4
Initial plan
Copilot Feb 13, 2026
4df57f7
Make container app/website provisioning depend on role assignment pro…
Copilot Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/Aspire.Hosting.Azure.AppContainers/AzureContainerAppResource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,18 @@ public AzureContainerAppResource(string name, Action<AzureResourceInfrastructure
var pushSteps = context.GetSteps(targetResource, WellKnownPipelineTags.PushContainerImage);
provisionSteps.DependsOn(pushSteps);

// The app deployment should depend on role assignment and identity provisioning for the target resource
// This ensures role assignments and private endpoints are ready before the app is deployed
var roleAssignmentPrefix = $"{targetResource.Name}-roles-";
foreach (var resource in context.Model.Resources)
{
if (resource.Name.StartsWith(roleAssignmentPrefix, StringComparison.Ordinal))
{
var roleSteps = context.GetSteps(resource, WellKnownPipelineTags.ProvisionInfrastructure);
provisionSteps.DependsOn(roleSteps);
}
}

// Ensure summary step runs after provision
context.GetSteps(this, "print-summary").DependsOn(provisionSteps);
}));
Expand Down
12 changes: 12 additions & 0 deletions src/Aspire.Hosting.Azure.AppService/AzureAppServiceWebSiteResource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,18 @@ public AzureAppServiceWebSiteResource(string name, Action<AzureResourceInfrastru
var pushSteps = context.GetSteps(targetResource, WellKnownPipelineTags.PushContainerImage);
provisionSteps.DependsOn(pushSteps);

// The app deployment should depend on role assignment and identity provisioning for the target resource
// This ensures role assignments and private endpoints are ready before the app is deployed
var roleAssignmentPrefix = $"{targetResource.Name}-roles-";
foreach (var resource in context.Model.Resources)
{
if (resource.Name.StartsWith(roleAssignmentPrefix, StringComparison.Ordinal))
{
var roleSteps = context.GetSteps(resource, WellKnownPipelineTags.ProvisionInfrastructure);
provisionSteps.DependsOn(roleSteps);
}
}

// Ensure summary step runs after provision
context.GetSteps(this, "print-summary").DependsOn(provisionSteps);
}));
Expand Down
34 changes: 17 additions & 17 deletions ...Tests.DeployAsync_WithAzureResourceDependencies_DoesNotHang_step=diagnostics.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,15 @@ Steps with no dependencies run first, followed by steps that depend on them.
6. validate-azure-login
7. create-provisioning-context
8. provision-api-identity
9. provision-env-acr
10. provision-env
11. provision-kv
12. login-to-acr-env-acr
13. push-prereq
14. push-api
15. provision-api-website
16. print-api-summary
17. provision-api-roles-kv
9. provision-kv
10. provision-api-roles-kv
11. provision-env-acr
12. provision-env
13. login-to-acr-env-acr
14. push-prereq
15. push-api
16. provision-api-website
17. print-api-summary
18. provision-azure-bicep-resources
19. print-dashboard-url-env
20. deploy
Expand Down Expand Up @@ -120,7 +120,7 @@ Step: provision-api-roles-kv

Step: provision-api-website
Description: Provisions the Azure Bicep resource api-website using Azure infrastructure.
Dependencies: ✓ create-provisioning-context, ✓ provision-api-identity, ✓ provision-env, ✓ provision-kv, ✓ push-api
Dependencies: ✓ create-provisioning-context, ✓ provision-api-identity, ✓ provision-api-roles-kv, ✓ provision-env, ✓ provision-kv, ✓ push-api
Resource: api-website (AzureAppServiceWebSiteResource)
Tags: provision-infra

Expand Down Expand Up @@ -251,14 +251,14 @@ If targeting 'deploy':

If targeting 'deploy-api':
Direct dependencies: print-api-summary
Total steps: 16
Total steps: 17
Execution order:
[0] process-parameters
[1] build-prereq | deploy-prereq (parallel)
[2] build-api | validate-azure-login (parallel)
[3] create-provisioning-context
[4] provision-api-identity | provision-env-acr | provision-kv (parallel)
[5] login-to-acr-env-acr | provision-env (parallel)
[5] login-to-acr-env-acr | provision-api-roles-kv | provision-env (parallel)
[6] push-prereq
[7] push-api
[8] provision-api-website
Expand Down Expand Up @@ -291,14 +291,14 @@ If targeting 'login-to-acr-env-acr':

If targeting 'print-api-summary':
Direct dependencies: provision-api-website
Total steps: 15
Total steps: 16
Execution order:
[0] process-parameters
[1] build-prereq | deploy-prereq (parallel)
[2] build-api | validate-azure-login (parallel)
[3] create-provisioning-context
[4] provision-api-identity | provision-env-acr | provision-kv (parallel)
[5] login-to-acr-env-acr | provision-env (parallel)
[5] login-to-acr-env-acr | provision-api-roles-kv | provision-env (parallel)
[6] push-prereq
[7] push-api
[8] provision-api-website
Expand Down Expand Up @@ -348,15 +348,15 @@ If targeting 'provision-api-roles-kv':
[5] provision-api-roles-kv

If targeting 'provision-api-website':
Direct dependencies: create-provisioning-context, provision-api-identity, provision-env, provision-kv, push-api
Total steps: 14
Direct dependencies: create-provisioning-context, provision-api-identity, provision-api-roles-kv, provision-env, provision-kv, push-api
Total steps: 15
Execution order:
[0] process-parameters
[1] build-prereq | deploy-prereq (parallel)
[2] build-api | validate-azure-login (parallel)
[3] create-provisioning-context
[4] provision-api-identity | provision-env-acr | provision-kv (parallel)
[5] login-to-acr-env-acr | provision-env (parallel)
[5] login-to-acr-env-acr | provision-api-roles-kv | provision-env (parallel)
[6] push-prereq
[7] push-api
[8] provision-api-website
Expand Down
44 changes: 22 additions & 22 deletions ...ests.DeployAsync_WithRedisAccessKeyAuthentication_CreatesCorrectDependencies.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,21 +23,21 @@ Steps with no dependencies run first, followed by steps that depend on them.
7. create-provisioning-context
8. provision-api-identity
9. provision-cache-kv
10. provision-cache
10. provision-api-roles-cache-kv
11. provision-cosmos-kv
12. provision-cosmos
13. provision-env-acr
14. provision-env
15. provision-pg-kv
16. provision-pg
17. login-to-acr-env-acr
18. push-prereq
19. push-api
20. provision-api-website
21. print-api-summary
22. provision-api-roles-cache-kv
23. provision-api-roles-cosmos-kv
24. provision-api-roles-pg-kv
12. provision-api-roles-cosmos-kv
13. provision-pg-kv
14. provision-api-roles-pg-kv
15. provision-cache
16. provision-cosmos
17. provision-env-acr
18. provision-env
19. provision-pg
20. login-to-acr-env-acr
21. push-prereq
22. push-api
23. provision-api-website
24. print-api-summary
25. provision-azure-bicep-resources
26. print-dashboard-url-env
27. deploy
Expand Down Expand Up @@ -139,7 +139,7 @@ Step: provision-api-roles-pg-kv

Step: provision-api-website
Description: Provisions the Azure Bicep resource api-website using Azure infrastructure.
Dependencies: ✓ create-provisioning-context, ✓ provision-api-identity, ✓ provision-cache, ✓ provision-cache-kv, ✓ provision-cosmos, ✓ provision-cosmos-kv, ✓ provision-env, ✓ provision-pg, ✓ provision-pg-kv, ✓ push-api
Dependencies: ✓ create-provisioning-context, ✓ provision-api-identity, ✓ provision-api-roles-cache-kv, ✓ provision-api-roles-cosmos-kv, ✓ provision-api-roles-pg-kv, ✓ provision-cache, ✓ provision-cache-kv, ✓ provision-cosmos, ✓ provision-cosmos-kv, ✓ provision-env, ✓ provision-pg, ✓ provision-pg-kv, ✓ push-api
Resource: api-website (AzureAppServiceWebSiteResource)
Tags: provision-infra

Expand Down Expand Up @@ -300,14 +300,14 @@ If targeting 'deploy':

If targeting 'deploy-api':
Direct dependencies: print-api-summary
Total steps: 21
Total steps: 24
Execution order:
[0] process-parameters
[1] build-prereq | deploy-prereq (parallel)
[2] build-api | validate-azure-login (parallel)
[3] create-provisioning-context
[4] provision-api-identity | provision-cache-kv | provision-cosmos-kv | provision-env-acr | provision-pg-kv (parallel)
[5] login-to-acr-env-acr | provision-cache | provision-cosmos | provision-env | provision-pg (parallel)
[5] login-to-acr-env-acr | provision-api-roles-cache-kv | provision-api-roles-cosmos-kv | provision-api-roles-pg-kv | provision-cache | provision-cosmos | provision-env | provision-pg (parallel)
[6] push-prereq
[7] push-api
[8] provision-api-website
Expand Down Expand Up @@ -340,14 +340,14 @@ If targeting 'login-to-acr-env-acr':

If targeting 'print-api-summary':
Direct dependencies: provision-api-website
Total steps: 20
Total steps: 23
Execution order:
[0] process-parameters
[1] build-prereq | deploy-prereq (parallel)
[2] build-api | validate-azure-login (parallel)
[3] create-provisioning-context
[4] provision-api-identity | provision-cache-kv | provision-cosmos-kv | provision-env-acr | provision-pg-kv (parallel)
[5] login-to-acr-env-acr | provision-cache | provision-cosmos | provision-env | provision-pg (parallel)
[5] login-to-acr-env-acr | provision-api-roles-cache-kv | provision-api-roles-cosmos-kv | provision-api-roles-pg-kv | provision-cache | provision-cosmos | provision-env | provision-pg (parallel)
[6] push-prereq
[7] push-api
[8] provision-api-website
Expand Down Expand Up @@ -419,15 +419,15 @@ If targeting 'provision-api-roles-pg-kv':
[5] provision-api-roles-pg-kv

If targeting 'provision-api-website':
Direct dependencies: create-provisioning-context, provision-api-identity, provision-cache, provision-cache-kv, provision-cosmos, provision-cosmos-kv, provision-env, provision-pg, provision-pg-kv, push-api
Total steps: 19
Direct dependencies: create-provisioning-context, provision-api-identity, provision-api-roles-cache-kv, provision-api-roles-cosmos-kv, provision-api-roles-pg-kv, provision-cache, provision-cache-kv, provision-cosmos, provision-cosmos-kv, provision-env, provision-pg, provision-pg-kv, push-api
Total steps: 22
Execution order:
[0] process-parameters
[1] build-prereq | deploy-prereq (parallel)
[2] build-api | validate-azure-login (parallel)
[3] create-provisioning-context
[4] provision-api-identity | provision-cache-kv | provision-cosmos-kv | provision-env-acr | provision-pg-kv (parallel)
[5] login-to-acr-env-acr | provision-cache | provision-cosmos | provision-env | provision-pg (parallel)
[5] login-to-acr-env-acr | provision-api-roles-cache-kv | provision-api-roles-cosmos-kv | provision-api-roles-pg-kv | provision-cache | provision-cosmos | provision-env | provision-pg (parallel)
[6] push-prereq
[7] push-api
[8] provision-api-website
Expand Down