Update SDK

[halter73]

No description provided.

[ghost]

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

[halter73]

Error message
Assert.Equal() Failure
↓ (pos 0)
Expected: /images/red.png
Actual:   ~/images/red.png
↑ (pos 0)

Stack trace
   at Microsoft.AspNetCore.Mvc.FunctionalTests.HtmlGenerationTest.<HtmlGenerationWebSite_GeneratesExpectedResults_WithImageData>g__AssertImgElement|16_0(IElement imgElement, Dictionary`2 expectedAttributes) in /_/src/Mvc/test/Mvc.FunctionalTests/HtmlGenerationTest.cs:line 202
   at Microsoft.AspNetCore.Mvc.FunctionalTests.HtmlGenerationTest.HtmlGenerationWebSite_GeneratesExpectedResults_WithImageData() in /_/src/Mvc/test/Mvc.FunctionalTests/HtmlGenerationTest.cs:line 137
--- End of stack trace from previous location ---

https://dev.azure.com/dnceng-public/public/_build/results?buildId=321048&view=ms.vss-test-web.build-test-results-tab&runId=6585140&resultId=121888&paneView=debug

@dotnet/razor-compiler There seems to be an issue with the razor SDK somewhere between 8.0.100-preview.7.23321.23 and 8.0.100-preview.7.23325.3. I did a little investigation and found this corresponds to dotnet/razor@f7483d3...c3de764. f7483d386b01ec87d1a284817732c60711e242bf was only from last Wednesday, so that narrows it down a bit, but there are much older commits merged in there.

Looking at the decompilation from the above failing test, I noticed that when compiled with the new SDK, Views_HtmlGeneration_Home_Image no longer includes any reference to UrlResolutionTagHelper. Razor now just skipss straight to adding the ImageTagHelper.

aspnetcore/src/Mvc/test/WebSites/HtmlGenerationWebSite/Views/HtmlGeneration_Home/Image.cshtml

Lines 13 to 14 in d92a95f

	<!-- Plain image tag -->
	<img src="~/images/red.png" alt="Red block" title="&lt;the title>" id="1">

aspnetcore/src/Mvc/Mvc.Razor/src/TagHelpers/UrlResolutionTagHelper.cs

Lines 48 to 49 in d92a95f

	[HtmlTargetElement("video", Attributes = "[poster^='~/']")]
	public class UrlResolutionTagHelper : TagHelper

which makes me wonder if the razor compiler isn't picking up the [HtmlTargetElement("img", Attributes = "[src^='~/']", TagStructure = TagStructure.WithoutEndTag)] for some reason. That's the one I figure would apply here.

[jjonescz]

Thanks for the investigation @halter73, I can reproduce this. Seems it's caused by adding global:: to @addTagHelper directives in dotnet/razor#8857. One of the directives is for UrlResolutionTagHelper:

-@addTagHelper Microsoft.AspNetCore.Mvc.Razor.TagHelpers.UrlResolutionTagHelper, Microsoft.AspNetCore.Mvc.Razor
+@addTagHelper global::Microsoft.AspNetCore.Mvc.Razor.TagHelpers.UrlResolutionTagHelper, Microsoft.AspNetCore.Mvc.Razor

I would expect that to work. Will investigate and fix it or revert that part of the PR.

[halter73]

We're now blocked on dotnet/installer#16864 before we can consume the razor fix in dotnet/razor#8871.

[Tratcher]

Try again after #49113 (or its replacement) fixes e2e (now required).

[Tratcher]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[javiercn]

@dotnet/aspnet-build any thoughts about the issues here? There seem to be new warnings about globalization, but I'm not sure what action should we take.

[javiercn]

@mavasani can you take a look? It's seems to be a bug that is blocking our update.

[mavasani]

@javiercn This update to CA1305 is coming from dotnet/roslyn-analyzers#6730, which fixed dotnet/roslyn-analyzers#6586. It seems the new CA1305 violations in the PR are indeed valid ones. You can attempt to fix the new violations, or suppress them in source with pragma suppressions/SuppressMessageAttributes.

[javiercn]

@mavasani I'm seeing warnings like this:

[eerhardt]

LGTM. Thanks for making the "easy" fix.