This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Treat EDI as killed by MaskMove#17673
Merged
CarolEidt merged 1 commit intodotnet:masterfrom Apr 21, 2018
Merged
Conversation
Author
|
@dotnet/jit-contrib PTAL |
|
Thanks for the work!! |
BruceForstall
approved these changes
Apr 19, 2018
BruceForstall
left a comment
BruceForstall
left a comment
There was a problem hiding this comment.
LGTM
Though it would be useful for there to be some comment in the code about why NI_SSE2_MaskMove needs this.
|
Will this PR be merged in 2.1? |
It should really only be a fixed reference, not a kill, but if the reference is changed by `LinearScan::resolveConflictingDefAndUse()` it can fail to cause the value in EDI to be killed. Fix #17634
Author
No, I am not planning to submit this for consideration to be ported to 2.1. Here is my reasoning for this:
|
|
Got it, thanks for the detailed explanation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should really only be a fixed reference, not a kill, but if the reference is changed by
LinearScan::resolveConflictingDefAndUse()it can fail to cause the value in EDI to be killed.