Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Exclude GT_ROL/ROR from ==/!= 0 compare peep optimization#7943

Merged
sivarv merged 1 commit intodotnet:masterfrom
sivarv:rotateFix
Nov 2, 2016
Merged

Exclude GT_ROL/ROR from ==/!= 0 compare peep optimization#7943
sivarv merged 1 commit intodotnet:masterfrom
sivarv:rotateFix

Conversation

@sivarv
Copy link
Copy Markdown
Member

@sivarv sivarv commented Nov 2, 2016

Rotate Left/Right xarch instructions don't set ZF and SF flags.
Only shift instructions set ZF/SF flags.

@sivarv
Copy link
Copy Markdown
Member Author

sivarv commented Nov 2, 2016

@briansull - Please review this.
CC @dotnet/jit-contrib

@erozenfeld
Copy link
Copy Markdown
Member

LGTM

@sivarv sivarv merged commit a4e26c8 into dotnet:master Nov 2, 2016
@briansull
Copy link
Copy Markdown

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants