This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Change EnsureBufferContainsAsync to ValueTask#40519
Closed
benaadams wants to merge 1 commit intodotnet:masterfrom
Closed
Change EnsureBufferContainsAsync to ValueTask#40519benaadams wants to merge 1 commit intodotnet:masterfrom
benaadams wants to merge 1 commit intodotnet:masterfrom
Conversation
Member
|
Thanks, but I don't want to change this unless that changes go in (without it, there's only downside to such a change), and if it does go in, there's many more functions in corefx that should be changed besides this one; I don't want to do them piecemeal. |
Member
Author
|
Fair enough :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With dotnet/coreclr#26310 this prevents it allocating Tasks in the common case
Pre
Post
/cc @stephentoub