fix: Place .playwright directory under bin directory#10399
Merged
yufeih merged 1 commit intodotnet:mainfrom Nov 19, 2024
Merged
fix: Place .playwright directory under bin directory#10399yufeih merged 1 commit intodotnet:mainfrom
.playwright directory under bin directory#10399yufeih merged 1 commit intodotnet:mainfrom
Conversation
yufeih
approved these changes
Nov 19, 2024
This was referenced Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intended to fix issue #10398.
By temporary revert commit (#9363)
Background
When using
PLAYWRIGHT_NODEJS_PATHenvironment variable.../../.playwrightfallback from bin directory is not used.And failed to find
.playwright\package\cli.jsfile.To fix problems. it need to change
playwright-dotnetside code(or install chromium browser directly by calling
.playwright/package/cli.js)So I've temporary reverted #9363 code. And place
.playwrightfolder under bin directory.By this changes.
.nupkgsize increased about1.8MB.