Skip to content

Documentation for System.Net.Http.SocketsHttpHandler.ConnectCallback #4861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aik-jahoda merged 3 commits into from
Sep 21, 2020
Merged

Documentation for System.Net.Http.SocketsHttpHandler.ConnectCallback #4861

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d5ab9f
Documentation for System.Net.Http.SocketsHttpHandler.ConnectCallback
Sep 16, 2020
4788b21
Apply PR comments
Sep 17, 2020
5fb870a
Apply suggestions from code review
aik-jahoda Sep 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions xml/System.Net.Http/SocketsHttpConnectionContext.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
</Base>
<Interfaces />
<Docs>
<summary>To be added.</summary>
<summary>Represents the context passed to the <see cref="P:System.Net.Http.SocketsHttpHandler.ConnectCallback" /> for a <see cref="T:System.Net.Http.SocketsHttpHandler" /> instance. .</summary>
<remarks>To be added.</remarks>
</Docs>
<Members>
Expand All @@ -34,7 +34,7 @@
<ReturnType>System.Net.DnsEndPoint</ReturnType>
</ReturnValue>
<Docs>
<summary>To be added.</summary>
<summary>The DnsEndPoint to be used by the ConnectCallback to establish the connection.</summary>
Comment thread
aik-jahoda marked this conversation as resolved.
Outdated
<value>To be added.</value>
<remarks>To be added.</remarks>
</Docs>
Expand All @@ -55,7 +55,7 @@
<ReturnType>System.Net.Http.HttpRequestMessage</ReturnType>
</ReturnValue>
<Docs>
<summary>To be added.</summary>
<summary>The initial HttpRequestMessage that is causing the connection to be created.</summary>
Comment thread
aik-jahoda marked this conversation as resolved.
Outdated
<value>To be added.</value>
<remarks>To be added.</remarks>
</Docs>
Expand Down
4 changes: 2 additions & 2 deletions xml/System.Net.Http/SocketsHttpHandler.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,8 @@ If this change is undesirable, you can configure your application to use the old
<ReturnType>System.Func&lt;System.Net.Http.SocketsHttpConnectionContext,System.Threading.CancellationToken,System.Threading.Tasks.ValueTask&lt;System.IO.Stream&gt;&gt;</ReturnType>
</ReturnValue>
<Docs>
<summary>To be added.</summary>
<value>To be added.</value>
<summary>Gets or sets a custom callback used to open new connections.</summary>
<value>A callback method to create a stream.</value>
<remarks>To be added.</remarks>
</Docs>
</Member>
Expand Down