Skip to content

Different images to build and run wasm#614

Merged
thaystg merged 5 commits intodotnet:mainfrom
thaystg:differente_images_to_build_and_run_wasm
May 4, 2022
Merged

Different images to build and run wasm#614
thaystg merged 5 commits intodotnet:mainfrom
thaystg:differente_images_to_build_and_run_wasm

Conversation

@thaystg
Copy link
Copy Markdown
Member

@thaystg thaystg commented May 3, 2022

@thaystg thaystg requested review from MattGal, lewing and radekdoulik May 3, 2022 19:21
@ghost ghost added the area-dockerfiles label May 3, 2022
remove package from build image
@@ -0,0 +1,31 @@
FROM ubuntu:18.04
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason this can't be based on the Ubuntu 18.04 Helix image instead?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done :)

@thaystg thaystg requested review from mthalman and radical May 3, 2022 21:34
Copy link
Copy Markdown
Member

@MattGal MattGal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming it builds

@thaystg thaystg merged commit 45f2c31 into dotnet:main May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test reporter logging is owned by root if first work item is docker work item

3 participants