Skip to content

Target .NET 6.0 with ef6#2166

Merged
bricelam merged 2 commits intodotnet:release/6.5from
ErikEJ:ef6-retarget
Nov 8, 2023
Merged

Target .NET 6.0 with ef6#2166
bricelam merged 2 commits intodotnet:release/6.5from
ErikEJ:ef6-retarget

Conversation

@ErikEJ
Copy link
Contributor

@ErikEJ ErikEJ commented Oct 27, 2023

No description provided.

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Oct 27, 2023

@bricelam What do you think? No more net3.x any more at least!

@bricelam
Copy link
Contributor

Hmm, it's a breaking change, but 3.1 and 5.0 are out of support, so maybe it's acceptable. Let me see if it avoids downloading the problematic DLLs. If it does, I'll discuss it with the team.

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Oct 27, 2023

Looking forward to the outcome!

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Oct 28, 2023

@bricelam Just verified that 3.0.3 is no longer downloaded:

In artifacts\obj\ef6\project.assets.json

        "downloadDependencies": [
          {
            "name": "Microsoft.AspNetCore.App.Runtime.win-arm64",
            "version": "[6.0.23, 6.0.23]"
          },
          {
            "name": "Microsoft.NETCore.App.Runtime.win-arm64",
            "version": "[6.0.23, 6.0.23]"
          },
          {
            "name": "Microsoft.WindowsDesktop.App.Runtime.win-arm64",
            "version": "[6.0.23, 6.0.23]"
          }
        ],
        "frameworkReferences": {
          "Microsoft.NETCore.App": {
            "privateAssets": "all"
          }
        },

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Nov 3, 2023

@bricelam ,Did you reach a conclusion? 😉

@bricelam
Copy link
Contributor

bricelam commented Nov 8, 2023

Met yesterday. We all agree it's OK to make this breaking change.

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Nov 8, 2023

Wauw - you made my day! 😄

@bricelam
Copy link
Contributor

bricelam commented Nov 8, 2023

lol, I'm trying not to get my hopes up. Every time I think we're close to releasing, something seems to go wrong. 🤞

@bricelam bricelam changed the base branch from main to release/6.5 November 8, 2023 17:51
@bricelam bricelam self-assigned this Nov 8, 2023
@bricelam bricelam merged commit 15e4587 into dotnet:release/6.5 Nov 8, 2023
@bricelam
Copy link
Contributor

Well, we fixed one of the issues. Two more to go... ☹️

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Nov 10, 2023

@bricelam Let me know if I can help

@bricelam
Copy link
Contributor

One of the errors is related to dotnet/efcore#32108, so that should eventually get resolved. I'll work on resolving the remaining error.

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Nov 14, 2023

@David-Engel Was a 5.1.3 release with an updated Azure.Identity planned? And if so, when?

@bricelam Will adding an explicit reference fix this?

@David-Engel
Copy link

We have a MDS 5.1 hotfix release with the updated dependency scheduled for early January. It'll be 5.1.4.

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Nov 14, 2023

@David-Engel Thank you so much!

@bricelam
Copy link
Contributor

Yay, PR #2175 fixed the other issue.

Will adding an explicit reference fix this?

It would make the error go away, but no, I wouldn't say it fixes the actual issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants