Adding support for any collection in ExpressionEqualityComparer #37212

[kirolous-nashaat]

Extend GetHashCode to handle IEnumerable objects, ensuring proper hash code generation for collections.

Add support for comparing IEnumerable objects using SequenceEqual, enhancing robustness for constant value comparisons.

Closes #37212

• I've read the guidelines for contributing and seen the walkthrough
• I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
• The code builds and tests pass locally (also verified by our automated build checks)
• Commit messages follow this format:
• Tests for the changes have been added (for bug fixes / features)
  Existing test already cover this, removed the old workaround for ignore query filters
• Code follows the same patterns and style as existing code in this repo

[roji]

@kirolous-nashaat thanks for submitting and sorry it took so long to review.

The PR looks good, but enumerating in this way over any IEnumerable could potentially be problematic; IEnumerables aren't necessarily materialized collections, and enumerating them can be arbitrarily expensive. I've opened #37684 to look into materializing IEnumerables early, at which point your PR would be totally fine. I'll take a look at that first.

[roji]

I've looked at this, and #37684 presents some difficulties. It's also not really necessary to do it before this - the current behavior of having query cache misses - and the resulting constant query recompilation - is likely to be far worse than the enumeration here.

Note that parameterized lists/collections/enumerables isn't a problem, as these get extracted out beforehand by the funcletizer. So this likely affects a very small minority of scenarios in any case.

So I'm pushing a few style tweaks and will merge, thanks for your contribution!