Merge 2.2 to master #559
Merged
Merge 2.2 to master #559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change TFM to netcoreapp2.0
This reverts commit 775847a.
- Removed EF ApiCheck tests; not required for middleware. - Removed JB annotations and Check usage; align with other Diagnostics Pages projects. - Fixed code redundancies.
- Made EF calls async - Removed a slow, repeated DB existence check.
Remove NetStandard.Library.NetFramework
* Matches `.travis.yml` used in other repos
[auto-updated: dependencies]
…master [automated] Merge branch 'release/2.2' => 'master'
IHealthCheckPublisher allows you to configure and run health checks regularly inside an application, and push the notifications elsewhere. All publishers are part of a single queue with a configurable period and timeout.
…master [automated] Merge branch 'release/2.2' => 'master'
The link (https://github.com/aspnet/Home/blob/dev/CONTRIBUTING.md) was broken due to merging of repo's.
…master [automated] Merge branch 'release/2.2' => 'master'
Fixes aspnet/Diagnostics#511 and aspnet/Diagnostics#514 It's really confusing to people that we use Map. Users expect that the URL they provide for the health check middleware will only process exact matches. The way it behaves when using map is not optimal for some of the common patterns.
…master [automated] Merge branch 'release/2.2' => 'master'
- Renamed the property for configuration response caching headers - Renamed the options class to avoid conflicts with other type names Fixes aspnet/Diagnostics#509
…master [automated] Merge branch 'release/2.2' => 'master'
* Redesign HealthStatus (again) This change brings back the ability to return Healthy/Degraded/Unhealthy in a HealthCheckResult. We tried making this pass/fail in 2.2.0-preview3 and folks writing health checks for their own use pointed out (rightly so) that it was too limited. It's still possible for the app developer to configure the failure status of a health check, but it requires the health check author to cooperate. I also got rid of HealthStatus.Failed since it raises more questions than it answers. It's really not clear that it's valuable for a health check for behave different when throwing an unhandled exception. We would still recommend that a health check library handle exceptions that they know about and return `context.Registration.FailureStatus`.
…master [automated] Merge branch 'release/2.2' => 'master'
Prior to reorganization, this source code was found in https://github.com/aspnet/Diagnostics/tree/c802d5ef5fba1ba8dfbcb8c3741af2ba15e9d1aa
Prior to reorganization, this source code was found in https://github.com/aspnet/Diagnostics/tree/082d505977d72c75b68935c93c21feded6928e5f
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the master branch of health checks projects from aspnet/Diagnostics. cref #548