Conversation
natemcmaster
pushed a commit
that referenced
this pull request
Nov 7, 2018
natemcmaster
pushed a commit
that referenced
this pull request
Nov 16, 2018
Reflects the chosen naming of IHttpClientFactory and System.Net.Http namespace. Adds the ability to create named clients - built on top of named options - this means introducing an options type Also adds caching of handlers Resolves: #11 #4 #5 #6 ---------------- The options type looks a little wonky but humour me for a second here. Fundamentally I think it's the right strategy for us to cache *handlers* not clients. The handler is the thing that actually does connection management, and conveniently they are opaque and immutable once constructed. The HttpClient on the other hand *is* mutable. So if you do something like dispose it, or modify the big public mutable things, you do so for the rest of the callers in the system. I think that caching handlers, but not clients gets us everything we want. In addition using the HttpClient with either pattern (keep forever or dispose) will 'just work' without any complicated code or drawbacks for users. ------ So after establishing that, we need to a way to express both deferred operations that build a 'handler' pipeline, and deferred operations that modify an HttpClient - and that's what it looks like on the options type. We should add extension methods or maybe another builder if necessary to smooth it over, but I think we'll get pretty far with what I have until we start tying in 3rd party libraries.
natemcmaster
pushed a commit
to natemcmaster/Extensions
that referenced
this pull request
Dec 4, 2018
- Added tool to generate a set of known culture names from the OS/Fx - CultureInfoCache is now limited to only caching/returning cultures from the known list - dotnet#6
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aspnet/dnx#1473