Skip to content

Escape the JSON data before embedding in Evaluation reports #7238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
peterwald merged 2 commits into from
Jan 29, 2026
Merged

Escape the JSON data before embedding in Evaluation reports #7238

peterwald merged 2 commits into from
Jan 29, 2026

Conversation

@peterwald
Copy link
Member

@peterwald peterwald commented Jan 28, 2026 •
edited by dotnet-policy-service bot
Loading

Microsoft Reviewers: Open in CodeFlow

@peterwald peterwald requested a review from a team as a code owner January 28, 2026 17:00
Copilot AI review requested due to automatic review settings January 28, 2026 17:00
@github-actions github-actions bot added the area-ai-eval Microsoft.Extensions.AI.Evaluation and related label Jan 28, 2026
@peterwald peterwald enabled auto-merge (squash) January 28, 2026 17:04
Copilot AI reviewed Jan 28, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

shyamnamboodiripad
shyamnamboodiripad approved these changes Jan 29, 2026
View reviewed changes
Copy link
Contributor

@shyamnamboodiripad shyamnamboodiripad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏾modulo comments (some of which seem worth addressing) Thanks much for fixing!

@peterwald peterwald merged commit e73bed3 into dotnet:main Jan 29, 2026
6 checks passed
@peterwald peterwald deleted the escape-embedded-json branch January 29, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GrabYourPitchforks GrabYourPitchforks GrabYourPitchforks left review comments

@stephentoub stephentoub stephentoub left review comments

@shyamnamboodiripad shyamnamboodiripad shyamnamboodiripad approved these changes

Copilot code review Copilot Copilot left review comments

Assignees

@peterwald peterwald

Labels

area-ai-eval Microsoft.Extensions.AI.Evaluation and related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@peterwald @GrabYourPitchforks @stephentoub @shyamnamboodiripad