Skip to content

No need to type check implementation files when an .fsi file exists #10201

Closed

Description

@KevinRansom

Will has the details, and can fill this out more. There is a tremendous peformance gain when we don't typecheck implementation files that are not open.

Activity

  1. changed the title [-]No need to type check implementation files when an FSI file exists[/-] [+]No need to type check implementation files when an .fsi file exists[/+] on Sep 30, 2020
  2. abelbraaksma commented on Sep 30, 2020

    @abelbraaksma
    Contributor

    This would help sooooo much in large projects wrt tooling perf, and would be an extra benefit for adding fsi files (I usually don't).

  3. smoothdeveloper commented on Oct 1, 2020

    @smoothdeveloper
    Contributor

    Waiting for this optimization to land before opening again TypeChecker.fs 😄.

  4. heronbpv commented on Oct 1, 2020

    @heronbpv

    This would help sooooo much in large projects wrt tooling perf, and would be an extra benefit for adding fsi files (I usually don't).

    This. Never saw any reason to make a .fsi file, until now. Always seemed like redundant work.

  5. KevinRansom commented on Oct 1, 2020

    @KevinRansom
    ContributorAuthor

    @heronbpv, I'm with you, I don't like them when creating apps, however, if you are creating libraries for public consumption, they are very useful for controlling the visibility of the types and functions in the libraries.

  6. added this to the 16.9 milestone on Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions