Skip to content

Parser adds new line symbol to the source being parsed #3617

Closed

Description

@auduchinok
No description provided.

Activity

  1. dsyme commented on Sep 20, 2017

    @dsyme
    Contributor

    @auduchinok Could you give more context on why this is a problem

    Context I know is

    • New line is only added if the file doesn't already end in a new line
    • This applies only to ParseAndCheckFileInProject and ParseFileInProject

    But I don't know what specific problems it causes to add the new line character. Equally, I don't know why our tests are so sensitive to the character being there (beyond line number range reports - it's more dramatic than that I believe?)

    Thanks!
    don

  2. auduchinok commented on Sep 20, 2017

    @auduchinok
    MemberAuthor

    @dsyme Adding a new line changes AST ranges which we rely on. We currently map these ranges to R# document offsets using approach very similar to the one used in RoslynHelpers.fs except getting min of lines count and a range line. It works fine when an empty line isn't added to the source and leads to ArgumentOutOfRangeException otherwise.

  3. dsyme commented on Sep 20, 2017

    @dsyme
    Contributor

    @auduchinok OK thanks, that makes sense

  4. added
    Impact-Low(Internal MS Team use only) Describes an issue with limited impact on existing code.
    and removed on Sep 20, 2017
  5. dsyme commented on Sep 20, 2017

    @dsyme
    Contributor

    @auduchinok I'm labelling this a "Urgency Later" since we workaround it at the moment, but please feel free to submit a fix for it.

  6. added this to the Unknown milestone on Aug 25, 2018
  7. auduchinok commented on Jun 19, 2020

    @auduchinok
    MemberAuthor

    Fixed in #6001.

  8. modified the milestones: Backlog, 16.1 on Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area-LangService-APIBugImpact-Low(Internal MS Team use only) Describes an issue with limited impact on existing code.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions