Repository navigation
Allow to build LexBuffer from array without copying. #4882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -65,6 +65,7 @@ type internal LexBuffer<'Char> = | |
| member IsPastEndOfStream: bool with get,set | ||
|
|
||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FromArryNoCopy should go here
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Notice that
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok thanks |
||
| /// Create a lex buffer suitable for Unicode lexing that reads characters from the given array. | ||
| /// Important: does take ownership of the array. | ||
| static member FromChars: char[] -> LexBuffer<char> | ||
| /// Create a lex buffer that reads character or byte inputs by using the given function. | ||
| static member FromFunction: ('Char[] * int * int -> int) -> LexBuffer<'Char> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove the ; while you are touching this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, were left due to oversight.