-
Notifications
You must be signed in to change notification settings - Fork 558
Ensure Hot Reload works #24782
Copy link
Copy link
Open
Labels
featureA feature to be implementedA feature to be implemented
Milestone
Description
Hot Reload currently doesn't work for user assemblies that we modify during the build.
This typically happens at least for device builds (the registrar).
We need to avoid assembly modification for user assemblies when hot reload is enabled.
Work that needs to complete first:
- [meta] Replace the custom linker steps with different solutions #17693
- In particular a new registrar mode using the type map feature will be required.
- Do something about the PreserveSmartEnumConversions step:
macios/tools/dotnet-linker/PreserveSmartEnumConversionsStep.cs
Lines 37 to 38 in a92fbe4
// Hot Reload: we can't modify user assemblies when Hot Reload is enabled (otherwise Hot Reload won't work), // so we'll have to come up with a different solution (emit xml definition instead maybe?)
Then:
- Verify that a default debug build for device doesn't modify any user assemblies.
- Modifying BCL/NuGet assemblies (assemblies not build using a project / without source code) is OK.
- If we do modify user assemblies, figure out a solution.
References:
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
featureA feature to be implementedA feature to be implemented