[Rgen] Add properties to decide if a temp return variable is needed. by mandel-macaque · Pull Request #22139 · dotnet/macios

mandel-macaque · 2025-02-09T22:50:39Z

Add a new property to the data models that will allow us to make the decision if a temp variable is needed when generating the code for a method or property.

This changes a little the way we create parameters and types because we need the compilation target to know if a type needs a stret call. We do not use the NeedsStret in the equlas method because that information has not value when we are deciding if a type needs to be regenerated or not by the roslyn code generator.

Add a new property to the data models that will allow us to make the decision if a temp variable is needed when generating the code for a method or property.

github-actions · 2025-02-09T22:54:45Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

This reverts commit ccce35a.

vs-mobiletools-engineering-service2 · 2025-02-11T19:51:38Z

✅ [PR Build] Build passed (Build packages) ✅

Pipeline on Agent
Hash: d7013cc61b83b665608eafdc4328a24a68414775 [PR build]

vs-mobiletools-engineering-service2 · 2025-02-11T20:01:22Z

✅ [PR Build] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: d7013cc61b83b665608eafdc4328a24a68414775 [PR build]

vs-mobiletools-engineering-service2 · 2025-02-11T20:05:30Z

✅ [PR Build] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: d7013cc61b83b665608eafdc4328a24a68414775 [PR build]

vs-mobiletools-engineering-service2 · 2025-02-11T20:18:11Z

💻 [PR Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: d7013cc61b83b665608eafdc4328a24a68414775 [PR build]

vs-mobiletools-engineering-service2 · 2025-02-11T20:19:25Z

💻 [PR Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: d7013cc61b83b665608eafdc4328a24a68414775 [PR build]

vs-mobiletools-engineering-service2 · 2025-02-11T20:19:43Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: d7013cc61b83b665608eafdc4328a24a68414775 [PR build]

vs-mobiletools-engineering-service2 · 2025-02-11T20:26:11Z

💻 [PR Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: d7013cc61b83b665608eafdc4328a24a68414775 [PR build]

vs-mobiletools-engineering-service2 · 2025-02-11T20:29:02Z

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: d7013cc61b83b665608eafdc4328a24a68414775 [PR build]

vs-mobiletools-engineering-service2 · 2025-02-11T20:46:58Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

iOS: vsdrops gist ( ❗ Breaking changes ❗ )
tvOS: vsdrops gist ( ❗ Breaking changes ❗ )
MacCatalyst: vsdrops gist ( ❗ Breaking changes ❗ )
macOS: vsdrops gist ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: d7013cc61b83b665608eafdc4328a24a68414775 [PR build]

vs-mobiletools-engineering-service2 · 2025-02-11T22:53:14Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 7 tests failed, 114 tests passed.

Failures

❌ dotnettests tests (iOS)

1 tests failed, 0 tests passed.

Details

DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ dotnettests tests (MacCatalyst)

1 tests failed, 0 tests passed.

Details

DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ dotnettests tests (macOS)

1 tests failed, 0 tests passed.

Details

DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ dotnettests tests (tvOS)

1 tests failed, 0 tests passed.

Details

DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ monotouch tests (MacCatalyst)

3 tests failed, 12 tests passed.

Details

monotouch-test/Mac Catalyst/Release (managed static registrar, all optimizations): Failed (Test run failed.
Tests run: 3150 Passed: 2980 Inconclusive: 10 Failed: 1 Ignored: 169)
monotouch-test/Mac Catalyst/Release (NativeAOT): Failed (Test run failed.
Tests run: 3150 Passed: 2997 Inconclusive: 11 Failed: 1 Ignored: 152)
monotouch-test/Mac Catalyst/Release (NativeAOT, ARM64): Failed (Test run failed.
Tests run: 3150 Passed: 2998 Inconclusive: 10 Failed: 1 Ignored: 151)

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 10 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: d7013cc61b83b665608eafdc4328a24a68414775 [PR build]

mandel-macaque · 2025-02-12T10:31:18Z

Failures are unrelated to the changes.

mandel-macaque and others added 3 commits February 9, 2025 12:50

[Rgen] Add properties to decide if a temp return variable is needed.

740ce00

Add a new property to the data models that will allow us to make the decision if a temp variable is needed when generating the code for a method or property.

Auto-format source code

458ba9b

This comment has been minimized.

Sign in to view

Add missing docs.

a32b2cb

Base automatically changed from dev/mandel/need-stret to main February 10, 2025 17:41

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Feb 11, 2025

View reviewed changes

mandel-macaque added 2 commits February 11, 2025 14:13

Revert "Auto-format source code"

4c3259c

This reverts commit ccce35a.

If you make a typo, you have to work twice.

d7013cc

rolfbjarne approved these changes Feb 11, 2025

View reviewed changes

Comment thread src/rgen/Microsoft.Macios.Generator/DataModel/Method.Generator.cs

mandel-macaque merged commit 7300db6 into main Feb 12, 2025

mandel-macaque deleted the dev/mandel/needs-temp-return branch February 12, 2025 10:31

Conversation

mandel-macaque commented Feb 9, 2025

Uh oh!

github-actions Bot commented Feb 9, 2025

⚠️ Your code has been reformatted. ⚠️

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 11, 2025

✅ [PR Build] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 11, 2025

✅ [PR Build] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 11, 2025

✅ [PR Build] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 11, 2025

💻 [PR Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 11, 2025

💻 [PR Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 11, 2025

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 11, 2025

💻 [PR Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 11, 2025

❌ [CI Build] Windows Integration Tests failed ❌

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 11, 2025

✅ API diff for current PR / commit

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 11, 2025

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ dotnettests tests (iOS)

❌ dotnettests tests (MacCatalyst)

❌ dotnettests tests (macOS)