[Bgen] Simplify the NSValue BindAS generated code.#22257
Conversation
As with previous changes, move to use a method group instead of a lambda with a using block. We only add the new methods in those platforms that have the specifict frameworks by using partial class. That way we keep the code cleaner than with a collection of #if statements.
mandel-macaque
requested review from
dalexsoto and
rolfbjarne
as code owners
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💻 [CI Build #371130a] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| new(TypeCache.CMTimeRange, "ToCMTimeRange"), | ||
| new(TypeCache.CMTime, "ToCMTime"), | ||
| new(TypeCache.CMTimeMapping, "ToCMTimeMapping"), | ||
| new (TypeCache.CMVideoDimensions, "ToCMVideoDimensions"), |
There was a problem hiding this comment.
Whitespace is inconsistent here.
| @@ -0,0 +1,24 @@ | |||
| // Copyright (c) Microsoft Corporation. | |||
There was a problem hiding this comment.
You forgot to add this file to frameworks.sources.
| new(TypeCache.CoreGraphics_CGRect, "ToCGRect"), | ||
| new(TypeCache.CoreGraphics_CGSize, "ToCGSize"), | ||
| new(TypeCache.MKCoordinateSpan, "ToMKCoordinateSpan"), | ||
| }; |
There was a problem hiding this comment.
I think you need NSDirectionalEdgeInsets as well.
✅ [PR Build #99ecca0] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #99ecca0] Build passed (Detect API changes) ✅Pipeline on Agent |
|
🔥 Failed to compare API and create generator diff 🔥 Error: 'make' failed for the hash a8168d3. Pipeline on Agent |
✅ [PR Build #99ecca0] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [PR Build #99ecca0] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [PR Build #99ecca0] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [PR Build #99ecca0] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [PR Build #99ecca0] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #99ecca0] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 114 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
4 participants
As with previous changes, move to use a method group instead of a lambda with a using block.
We only add the new methods in those platforms that have the specifict frameworks by using partial class. That way we keep the code cleaner than with a collection of #if statements.