[RGen] Add a flag for the smart enum. by mandel-macaque · Pull Request #22270 · dotnet/macios

mandel-macaque · 2025-03-03T01:46:15Z

Using the BindingType attribute is an issue when we are trying to generate the code for an ErrorCode since we need to be able to provide the error domain. This change treats the SmartEnums as the rest of the bindings which will later will allow use to diff between a smart enum and an ErrorCode.

Using the BindingType attribute is an issue when we are tyring to generate the code for an ErrorCode since we need to be able to provide the error domain. This change treats the SmartEnums as the rest of the bindings which will later will allow use to diff between a smart enum and an ErrorCode.

github-actions · 2025-03-03T01:50:14Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

vs-mobiletools-engineering-service2 · 2025-03-03T13:32:47Z

✅ [PR Build #fb3c399] Build passed (Build packages) ✅

Pipeline on Agent
Hash: fb3c399b93a70cc41f3b05b0e3d746525ffdd84f [PR build]

vs-mobiletools-engineering-service2 · 2025-03-03T13:35:46Z

✅ [PR Build #fb3c399] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: fb3c399b93a70cc41f3b05b0e3d746525ffdd84f [PR build]

vs-mobiletools-engineering-service2 · 2025-03-03T13:42:16Z

✅ [PR Build #fb3c399] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: fb3c399b93a70cc41f3b05b0e3d746525ffdd84f [PR build]

vs-mobiletools-engineering-service2 · 2025-03-03T13:55:19Z

💻 [PR Build #fb3c399] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: fb3c399b93a70cc41f3b05b0e3d746525ffdd84f [PR build]

vs-mobiletools-engineering-service2 · 2025-03-03T13:56:12Z

💻 [PR Build #fb3c399] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: fb3c399b93a70cc41f3b05b0e3d746525ffdd84f [PR build]

vs-mobiletools-engineering-service2 · 2025-03-03T13:56:56Z

💻 [PR Build #fb3c399] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: fb3c399b93a70cc41f3b05b0e3d746525ffdd84f [PR build]

vs-mobiletools-engineering-service2 · 2025-03-03T13:57:01Z

💻 [PR Build #fb3c399] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: fb3c399b93a70cc41f3b05b0e3d746525ffdd84f [PR build]

vs-mobiletools-engineering-service2 · 2025-03-03T14:00:44Z

💻 [CI Build #fb3c399] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: fb3c399b93a70cc41f3b05b0e3d746525ffdd84f [PR build]

vs-mobiletools-engineering-service2 · 2025-03-03T14:07:47Z

❗ API diff for current PR / commit (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

iOS: vsdrops gist ( ❗ Breaking changes ❗ )
tvOS: vsdrops gist ( ❗ Breaking changes ❗ )
MacCatalyst: vsdrops gist ( ❗ Breaking changes ❗ )
macOS: vsdrops gist ( ❗ Breaking changes ❗ )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

iOS: vsdrops gist ( ❗ Breaking changes ❗ )
tvOS: vsdrops gist ( ❗ Breaking changes ❗ )
MacCatalyst: vsdrops gist ( ❗ Breaking changes ❗ )
macOS: vsdrops gist ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: fb3c399b93a70cc41f3b05b0e3d746525ffdd84f [PR build]

vs-mobiletools-engineering-service2 · 2025-03-03T16:36:14Z

🔥 [CI Build #fb3c399] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 1 tests failed, 113 tests passed.

Failures

❌ dotnettests tests (MacCatalyst)

1 tests failed, 0 tests passed.

Details

DotNet tests: TimedOut (Execution timed out after 165 minutes.)

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 10 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: fb3c399b93a70cc41f3b05b0e3d746525ffdd84f [PR build]

mandel-macaque requested a review from dalexsoto as a code owner March 3, 2025 01:46

Auto-format source code

a8bd1c1

This comment has been minimized.

Sign in to view

rolfbjarne approved these changes Mar 3, 2025

View reviewed changes

mandel-macaque added 2 commits March 3, 2025 07:49

Merge branch 'main' into dev/mandel/smart-enum-flag

884a436

Update known failures since we removed a file.

fb3c399

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Mar 3, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

mandel-macaque merged commit 71c1fa8 into main Mar 3, 2025

mandel-macaque deleted the dev/mandel/smart-enum-flag branch March 3, 2025 16:53

Conversation

mandel-macaque commented Mar 3, 2025 • edited by rolfbjarne Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Mar 3, 2025

⚠️ Your code has been reformatted. ⚠️

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Mar 3, 2025

✅ [PR Build #fb3c399] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 3, 2025

✅ [PR Build #fb3c399] Build passed (Detect API changes) ✅

Uh oh!

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Mar 3, 2025

✅ [PR Build #fb3c399] Build passed (Build macOS tests) ✅

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Mar 3, 2025

💻 [PR Build #fb3c399] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 3, 2025

💻 [PR Build #fb3c399] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Mar 3, 2025

💻 [PR Build #fb3c399] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 3, 2025

💻 [PR Build #fb3c399] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 3, 2025

💻 [CI Build #fb3c399] Windows Integration Tests passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 3, 2025

❗ API diff for current PR / commit (Breaking changes)

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Mar 3, 2025

🔥 [CI Build #fb3c399] Test results 🔥

Test results

Failures

❌ dotnettests tests (MacCatalyst)

Successes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mandel-macaque commented Mar 3, 2025 •

edited by rolfbjarne

Loading