[Rgen] Update transformers to take the binding struct in the message. by mandel-macaque · Pull Request #22327 · dotnet/macios

mandel-macaque · 2025-03-06T23:12:00Z

Now that we have the binding struct we can update the workers to get it and use its data to perform the needed transformation.

Add support to use the data model in the transformer. What we do know is: 1. Create a biding struct based on the compilation and the semantic model. 2. Select the topic based on the binding data. We are not yet sending the biding data to the transformer or taking into consideration that we need to deal with more than one platform yet.

Now that we have the binding struct we can update the workers to get it and use its data to perform the needed transformation.

github-actions · 2025-03-06T23:16:08Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

vs-mobiletools-engineering-service2 · 2025-03-09T17:09:53Z

✅ [CI Build #67530e4] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 67530e4be7d237a29e0dadafe6e3ef548c224c44 [PR build]

vs-mobiletools-engineering-service2 · 2025-03-09T17:12:36Z

✅ [PR Build #67530e4] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 67530e4be7d237a29e0dadafe6e3ef548c224c44 [PR build]

vs-mobiletools-engineering-service2 · 2025-03-09T17:35:41Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

iOS: vsdrops gist ( ❗ Breaking changes ❗ )
tvOS: vsdrops gist ( ❗ Breaking changes ❗ )
MacCatalyst: vsdrops gist ( ❗ Breaking changes ❗ )
macOS: vsdrops gist ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 67530e4be7d237a29e0dadafe6e3ef548c224c44 [PR build]

vs-mobiletools-engineering-service2 · 2025-03-09T17:45:58Z

💻 [CI Build #67530e4] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 67530e4be7d237a29e0dadafe6e3ef548c224c44 [PR build]

vs-mobiletools-engineering-service2 · 2025-03-09T18:39:47Z

🚀 [CI Build #67530e4] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 116 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 67530e4be7d237a29e0dadafe6e3ef548c224c44 [PR build]

vs-mobiletools-engineering-service2 · 2025-03-09T23:10:46Z

✅ [CI Build #67530e4] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 67530e4be7d237a29e0dadafe6e3ef548c224c44 [PR build]

vs-mobiletools-engineering-service2 · 2025-03-09T23:23:29Z

💻 [CI Build #67530e4] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 67530e4be7d237a29e0dadafe6e3ef548c224c44 [PR build]

vs-mobiletools-engineering-service2 · 2025-03-09T23:24:28Z

💻 [CI Build #67530e4] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 67530e4be7d237a29e0dadafe6e3ef548c224c44 [PR build]

vs-mobiletools-engineering-service2 · 2025-03-09T23:26:27Z

💻 [CI Build #67530e4] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 67530e4be7d237a29e0dadafe6e3ef548c224c44 [PR build]

vs-mobiletools-engineering-service2 · 2025-03-10T00:50:15Z

❌ [CI Build #67530e4] Tests on macOS arm64 - Mac Sequoia (15) failed ❌

Failed tests are:

monotouch-test

Pipeline on Agent
Hash: 67530e4be7d237a29e0dadafe6e3ef548c224c44 [PR build]

mandel-macaque and others added 3 commits March 6, 2025 17:39

[Rgen] Update transformers to take the binding struct in the message.

bec2c3d

Now that we have the binding struct we can update the workers to get it and use its data to perform the needed transformation.

Auto-format source code

da57c76

This comment has been minimized.

Sign in to view

rolfbjarne approved these changes Mar 7, 2025

View reviewed changes

dalexsoto approved these changes Mar 7, 2025

View reviewed changes

Base automatically changed from dev/mandel/transformer-create-binding-for-symbol to main March 7, 2025 22:45

Merge branch 'main' into dev/mandel/transformer-update-workers

67530e4

This comment has been minimized.

Sign in to view

StephaneDelcroix approved these changes Mar 10, 2025

View reviewed changes

mandel-macaque merged commit e5fc10d into main Mar 10, 2025

mandel-macaque deleted the dev/mandel/transformer-update-workers branch March 10, 2025 15:22

Conversation

mandel-macaque commented Mar 6, 2025

Uh oh!

github-actions Bot commented Mar 6, 2025

⚠️ Your code has been reformatted. ⚠️

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Mar 9, 2025

✅ [CI Build #67530e4] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 9, 2025

✅ [PR Build #67530e4] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 9, 2025

✅ API diff for current PR / commit

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 9, 2025

💻 [CI Build #67530e4] Windows Integration Tests passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 9, 2025

🚀 [CI Build #67530e4] Test results 🚀

Test results

Tests counts

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 9, 2025

✅ [CI Build #67530e4] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 9, 2025

💻 [CI Build #67530e4] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 9, 2025

💻 [CI Build #67530e4] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 9, 2025

💻 [CI Build #67530e4] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 10, 2025

❌ [CI Build #67530e4] Tests on macOS arm64 - Mac Sequoia (15) failed ❌

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants