[RGen] Generate code for properties that have a smart enum and a BindFrom attr. by mandel-macaque · Pull Request #22368 · dotnet/macios

mandel-macaque · 2025-03-11T18:16:57Z

Put the pieces together to generate the code for properites with a BindFrom (NSString) and a smart enum.

…ndle. Add the factory method to be used to generate the code needed to get a smart enum from a handle.

…From attr. Put the pieces together to generate the code for properites with a BindFrom (NSString) and a smart enum.

github-actions · 2025-03-11T18:20:59Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

vs-mobiletools-engineering-service2 · 2025-03-12T18:10:29Z

✅ [CI Build #902e7a3] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 902e7a35f3bd3c3d6361c9877504cba59c6bbcca [PR build]

vs-mobiletools-engineering-service2 · 2025-03-12T18:12:37Z

✅ [PR Build #902e7a3] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 902e7a35f3bd3c3d6361c9877504cba59c6bbcca [PR build]

vs-mobiletools-engineering-service2 · 2025-03-12T18:20:02Z

✅ [CI Build #902e7a3] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 902e7a35f3bd3c3d6361c9877504cba59c6bbcca [PR build]

vs-mobiletools-engineering-service2 · 2025-03-12T18:33:44Z

💻 [CI Build #902e7a3] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 902e7a35f3bd3c3d6361c9877504cba59c6bbcca [PR build]

vs-mobiletools-engineering-service2 · 2025-03-12T18:34:31Z

💻 [CI Build #902e7a3] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 902e7a35f3bd3c3d6361c9877504cba59c6bbcca [PR build]

vs-mobiletools-engineering-service2 · 2025-03-12T18:35:27Z

💻 [CI Build #902e7a3] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 902e7a35f3bd3c3d6361c9877504cba59c6bbcca [PR build]

vs-mobiletools-engineering-service2 · 2025-03-12T18:36:06Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

iOS: vsdrops gist ( ❗ Breaking changes ❗ )
tvOS: vsdrops gist ( ❗ Breaking changes ❗ )
MacCatalyst: vsdrops gist ( ❗ Breaking changes ❗ )
macOS: vsdrops gist ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 902e7a35f3bd3c3d6361c9877504cba59c6bbcca [PR build]

vs-mobiletools-engineering-service2 · 2025-03-12T18:37:09Z

💻 [CI Build #902e7a3] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 902e7a35f3bd3c3d6361c9877504cba59c6bbcca [PR build]

vs-mobiletools-engineering-service2 · 2025-03-12T19:01:40Z

💻 [CI Build #902e7a3] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 902e7a35f3bd3c3d6361c9877504cba59c6bbcca [PR build]

vs-mobiletools-engineering-service2 · 2025-03-12T20:46:01Z

🔥 [CI Build #902e7a3] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 1 tests failed, 114 tests passed.

Failures

❌ monotouch tests (iOS)

1 tests failed, 7 tests passed.

Details

monotouch-test/iOS - simulator/Release (NativeAOT, x64): Crashed

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 902e7a35f3bd3c3d6361c9877504cba59c6bbcca [PR build]

StephaneDelcroix · 2025-03-13T10:18:47Z

 					NSArrayFromHandleFunc (property.ReturnType.FullyQualifiedName, [Argument (objMsgSend), Argument(NSValueFromHandle (property.ReturnType)!), BoolArgument (false)]),
+
+				// bind from NSString to a SmartEnum: "global::AVFoundation.AVCaptureSystemPressureLevelExtensions.GetNullableValue (arg1)
+				{ BindAs.Type.FullyQualifiedName: "Foundation.NSString", ReturnType.IsSmartEnum: true} =>


I'm quite sur you can use ITypeSymbol.Equals, but this will work too

mandel-macaque and others added 3 commits March 11, 2025 13:32

[Rgen] Add factory method to retrieve the smart enum values from a ha…

452f6fd

…ndle. Add the factory method to be used to generate the code needed to get a smart enum from a handle.

Auto-format source code

c26e6a7

[RGen] Generate code for properties that have a smart enum and a Bind…

b40d343

…From attr. Put the pieces together to generate the code for properites with a BindFrom (NSString) and a smart enum.

This comment has been minimized.

Sign in to view

Auto-format source code

9d3d7ec

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Mar 11, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

rolfbjarne approved these changes Mar 12, 2025

View reviewed changes

Base automatically changed from dev/mandel/nsstring-enum-factory-methods to main March 12, 2025 16:27

Merge branch 'main' into dev/mandel/generate-smart-enum-bindas

902e7a3

StephaneDelcroix approved these changes Mar 13, 2025

View reviewed changes

mandel-macaque merged commit ecd67d8 into main Mar 13, 2025

mandel-macaque deleted the dev/mandel/generate-smart-enum-bindas branch March 13, 2025 12:36

Conversation

mandel-macaque commented Mar 11, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

github-actions Bot commented Mar 11, 2025

⚠️ Your code has been reformatted. ⚠️

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Mar 12, 2025

✅ [CI Build #902e7a3] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 12, 2025

✅ [PR Build #902e7a3] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 12, 2025

✅ [CI Build #902e7a3] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 12, 2025

💻 [CI Build #902e7a3] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 12, 2025

💻 [CI Build #902e7a3] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 12, 2025

💻 [CI Build #902e7a3] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 12, 2025

✅ API diff for current PR / commit

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 12, 2025

💻 [CI Build #902e7a3] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 12, 2025

💻 [CI Build #902e7a3] Windows Integration Tests passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 12, 2025

🔥 [CI Build #902e7a3] Test results 🔥

Test results

Failures

❌ monotouch tests (iOS)

Successes

Uh oh!

StephaneDelcroix Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects