Skip to content

[Rgen] Extract the CFString.CreateNative expression to be reused.#22402

Merged
mandel-macaque merged 2 commits into
mainfrom
dev/mandel/extract-cfstring-create
Mar 14, 2025
Merged

[Rgen] Extract the CFString.CreateNative expression to be reused.#22402
mandel-macaque merged 2 commits into
mainfrom
dev/mandel/extract-cfstring-create

Conversation

@mandel-macaque
Copy link
Copy Markdown
Contributor

The expression is needed to write the trampolines, extract it from the current methods that use it to be reused.

No need for tests since we already have test that exercise the method.

mandel-macaque and others added 2 commits March 14, 2025 13:15
The expression is needed to write the trampolines, extract it from the
current methods that use it to be reused.
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [PR Build #fec27eb] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: fec27eb4e562997a699576316df6c5dadaac735e [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [CI Build #10c4faf] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 10c4fafc5b91b82cba1e6c9e4cbb466b04a914d1 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: fec27eb4e562997a699576316df6c5dadaac735e [PR build]

/// </summary>
/// <param name="arguments">The argument list for the invocation.</param>
/// <returns>The expression to call the CFString.CreateNative method with the provided args.</returns>
internal static InvocationExpressionSyntax StringCreateNative (ImmutableArray<ArgumentSyntax> arguments)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about CFString.ReleaseNative? They usually are used together :)

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [CI Build #10c4faf] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 10c4fafc5b91b82cba1e6c9e4cbb466b04a914d1 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

💻 [CI Build #10c4faf] Windows Integration Tests passed 💻

All Windows Integration Tests passed.

Pipeline on Agent
Hash: 10c4fafc5b91b82cba1e6c9e4cbb466b04a914d1 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

💻 [CI Build #10c4faf] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 10c4fafc5b91b82cba1e6c9e4cbb466b04a914d1 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

💻 [CI Build #10c4faf] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 10c4fafc5b91b82cba1e6c9e4cbb466b04a914d1 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

💻 [CI Build #10c4faf] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 10c4fafc5b91b82cba1e6c9e4cbb466b04a914d1 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

❌ [CI Build #10c4faf] Tests on macOS arm64 - Mac Sequoia (15) failed ❌

Failed tests are:

  • monotouch-test

Pipeline on Agent
Hash: 10c4fafc5b91b82cba1e6c9e4cbb466b04a914d1 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

🚀 [CI Build #10c4faf] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 115 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 10c4fafc5b91b82cba1e6c9e4cbb466b04a914d1 [PR build]

@mandel-macaque mandel-macaque merged commit bb3a061 into main Mar 14, 2025
@mandel-macaque mandel-macaque deleted the dev/mandel/extract-cfstring-create branch March 14, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants