[Rgen] Extract the CFString.CreateNative expression to be reused.#22402
Conversation
The expression is needed to write the trampolines, extract it from the current methods that use it to be reused.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #fec27eb] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ [CI Build #10c4faf] Build passed (Build packages) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ API diff for current PR / commit.NET ( No breaking changes )❗ API diff vs stable (Breaking changes).NET ( ❗ Breaking changes ❗ )ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
| /// </summary> | ||
| /// <param name="arguments">The argument list for the invocation.</param> | ||
| /// <returns>The expression to call the CFString.CreateNative method with the provided args.</returns> | ||
| internal static InvocationExpressionSyntax StringCreateNative (ImmutableArray<ArgumentSyntax> arguments) |
There was a problem hiding this comment.
What about CFString.ReleaseNative? They usually are used together :)
✅ [CI Build #10c4faf] Build passed (Build macOS tests) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
💻 [CI Build #10c4faf] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
💻 [CI Build #10c4faf] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #10c4faf] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #10c4faf] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
❌ [CI Build #10c4faf] Tests on macOS arm64 - Mac Sequoia (15) failed ❌Failed tests are:
Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #10c4faf] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 115 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
The expression is needed to write the trampolines, extract it from the current methods that use it to be reused.
No need for tests since we already have test that exercise the method.