[dotnet] Add a 'EnableProfiler' property to enable the 'diagnostics_tracing' component. Fixes #19370.#22685
Conversation
✅ [CI Build #f0a2184] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #f0a2184] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commit.NET ( No breaking changes )✅ API diff vs stable.NET ( No breaking changes )✅ Generator diffGenerator diff is empty Pipeline on Agent |
✅ [CI Build #f0a2184] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #f0a2184] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #f0a2184] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #f0a2184] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #f0a2184] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
Will we also bring this to .NET 9? The Android change would be something like:
<AndroidEnableProfiler Condition="'$(AndroidEnableProfiler)' == ''">$(EnableProfiler)<AndroidEnableProfiler>So, it would be fine for .NET 9.
Context: dotnet/macios#22685 Context: dotnet/macios#19370 To simplify inclusion of the Mono diagnostics component, the iOS/macOS/etc. workloads are introducing a new `$(EnableProfiler)` property. To align with Android, we can make `$(EnableProfiler)` available and work the same way as the existing `$(AndroidEnableProfiler)` property. I documented `$(AndroidEnableProfiler)` (which was missing!), and also added an entry about the new, `$(EnableProfiler)` property.
Our |
🚀 [CI Build #f0a2184] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 115 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Context: dotnet/macios#22685 Context: dotnet/macios#19370 To simplify inclusion of the Mono diagnostics component, the iOS/macOS/etc. workloads are introducing a new `$(EnableProfiler)` MSBuild property. To align with Android, we can add an `$(EnableProfiler)` MSBuild property which works the same way as the existing `$(AndroidEnableProfiler)` MSBuild property. I documented `$(AndroidEnableProfiler)` (which was missing!), and also added an entry about the new, `$(EnableProfiler)` property.
Context: dotnet/macios#22685 Context: dotnet/macios#19370 To simplify inclusion of the Mono diagnostics component, the iOS/macOS/etc. workloads are introducing a new `$(EnableProfiler)` MSBuild property. To align with Android, we can add an `$(EnableProfiler)` MSBuild property which works the same way as the existing `$(AndroidEnableProfiler)` MSBuild property. I documented `$(AndroidEnableProfiler)` (which was missing!), and also added an entry about the new, `$(EnableProfiler)` property.
| <!-- that also encapsulates whether we're a library or not (this makes conditions simpler) --> | ||
| <_BundleOriginalResources Condition="'$(OutputType)' == 'Library' And '$(IsAppExtension)' != 'true' And '$(BundleOriginalResources)' == 'true'">true</_BundleOriginalResources> | ||
|
|
||
| <EnableProfiling Condition="'$(EnableProfiling)' == '' And '$(_BundlerDebug)' == 'true'">true</EnableProfiling> |
There was a problem hiding this comment.
this should probably be EnableProfiler instead of EnableProfiling
8 participants
Fixes #19370.