Partially revert "[Windows] Update CollectionView changing ItemsLayout (#14532)#18356
Merged
Conversation
emaf
force-pushed
the
dev/ema/revert-cv
branch
from
1382213 to
7f99b06
Compare
mattleibow
approved these changes
Oct 26, 2023
Member
|
We should re-open #7747 once this is merged. |
Member
|
@emaf you mentioned that GridView only measures the first item. Where is this info coming from? Your tests or is this documented? Is this a bug in the WASDK maybe? |
emaf
added a commit
that referenced
this pull request
Oct 26, 2023
emaf
added a commit
that referenced
this pull request
Oct 26, 2023
PureWeen
pushed a commit
that referenced
this pull request
Oct 27, 2023
PureWeen
pushed a commit
that referenced
this pull request
Oct 27, 2023
emaf
added a commit
that referenced
this pull request
Nov 3, 2023
PureWeen
pushed a commit
that referenced
this pull request
Nov 6, 2023
emaf
added a commit
that referenced
this pull request
Nov 10, 2023
samhouts
added
the
fixed-in-8.0.100-rc.2.9530
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This partially reverts commit d569287, keeping the AdaptiveCollectionView sample.
The reverted change was switching to only use FormsGridView as backing control for CollectionView what causes issues like #16234.
This re-introduces #7747.
Issues Fixed
Fixes #16234
Fixes #18128