Skip to content

Fix project name substitution in Blazor template nav menu and "VS install" prompt#18388

Merged
PureWeen merged 2 commits into
net8.0from
eilon/fix-blazor-template-subst
Oct 27, 2023
Merged

Fix project name substitution in Blazor template nav menu and "VS install" prompt#18388
PureWeen merged 2 commits into
net8.0from
eilon/fix-blazor-template-subst

Conversation

@Eilon
Copy link
Copy Markdown
Contributor

@Eilon Eilon commented Oct 26, 2023

Fixes #18382

@Eilon Eilon added area-blazor Blazor Hybrid / Desktop, BlazorWebView area-templates Project templates, Item Templates for Blazor and MAUI labels Oct 26, 2023
@Eilon Eilon requested a review from mattleibow October 26, 2023 19:19
@Eilon Eilon requested a review from a team as a code owner October 26, 2023 19:19
@@ -1,6 +1,6 @@
<div class="top-row ps-3 navbar navbar-dark">
<div class="container-fluid">
<a class="navbar-brand" href="">BlazorWeb-CSharp</a>
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a copy/paste accident when updating the templates to the latest Blazor. This should have used the MAUI project name substitution so that it gets replaced with whatever the user called their project.

mattleibow
mattleibow previously approved these changes Oct 26, 2023
@mattleibow mattleibow enabled auto-merge (squash) October 26, 2023 19:31
@Eilon Eilon disabled auto-merge October 26, 2023 21:17
@PureWeen PureWeen added this to the .NET 8 GA milestone Oct 26, 2023
@PureWeen PureWeen enabled auto-merge (squash) October 26, 2023 21:30
@Eilon Eilon changed the title Fix project name substitution in Blazor template nav menu Fix project name substitution in Blazor template nav menu and "VS install" prompt Oct 26, 2023
@PureWeen PureWeen merged commit 7694b20 into net8.0 Oct 27, 2023
@PureWeen PureWeen deleted the eilon/fix-blazor-template-subst branch October 27, 2023 00:17
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 5, 2023
@samhouts samhouts added the fixed-in-8.0.100-rc.2.9530 Look for this fix in 8.0.100-rc.2.9530 label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-blazor Blazor Hybrid / Desktop, BlazorWebView area-templates Project templates, Item Templates for Blazor and MAUI fixed-in-8.0.100-rc.2.9530 Look for this fix in 8.0.100-rc.2.9530

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants