Fixed entry text color [iOS] by kubaflo · Pull Request #20100 · dotnet/maui

kubaflo · 2024-01-23T10:30:49Z

Description of Change

Added MapFormatting() for MapText in Entry.iOS like it is done in EntryHandler.iOS

Issues Fixed

Fixes #19509
Fixes #19470
Fixes #19424

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-01-27.at.13.44.26.mp4

ghost · 2024-01-23T10:30:56Z

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

jfversluis · 2024-01-23T12:27:05Z

You're on fire @kubaflo thank you!

jfversluis · 2024-01-23T12:27:10Z

/azp run

azure-pipelines · 2024-01-23T12:27:30Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2024-01-23T12:45:41Z

Thanks for the contribution. I can help adding UI tests here.

kubaflo · 2024-01-23T13:27:47Z

You're on fire @kubaflo thank you!

I'm still learning the MAUI codebase, but I try to be helpful! 😅

jsuarezruiz · 2024-01-23T15:36:22Z

Added UITest.

jsuarezruiz · 2024-02-02T13:05:03Z

/azp run

azure-pipelines · 2024-02-02T13:05:25Z

Azure Pipelines successfully started running 3 pipeline(s).

dartasen · 2024-03-21T11:44:59Z

@jsuarezruiz @jfversluis Any update on this ?

jfversluis · 2024-03-21T12:17:45Z

/azp run MAUI-UITests-public

azure-pipelines · 2024-03-22T12:20:12Z

Azure Pipelines successfully started running 1 pipeline(s).

shawncothran · 2024-03-25T19:29:35Z

@PureWeen or @jsuarezruiz any plan to move this one forward soon?

Zack-G-I-T · 2024-03-26T16:07:21Z

Any update on when this will be merged?

PureWeen · 2024-03-28T23:46:56Z

+
+		private static void MapFormatting(IEntryHandler handler, IEntry entry)
+		{
+			handler.PlatformView?.UpdateMaxLength(entry);


Instead of calling these directly can you propagate through the handler?

handler.UpdateValue(nameof(IEntry.MaxLength))

jfversluis

Also see a very lengthy discussion about this on the live stream here: https://www.youtube.com/watch?v=ERh9Ixz8f_Y

😄

jfversluis · 2024-04-04T18:40:14Z

+		{
+			base.OnAppearing();
+
+			await Task.Delay(1500);


What if we trigger the text change just with a button click instead of a delay? That might speed up things and is less arbitrary.

I did as you suggested and it does the job!

kmoo · 2024-04-04T19:58:03Z

+			// Any text update requires that we update any attributed string formatting
+			handler.UpdateValue(nameof(IEntry.MaxLength));
+			handler.UpdateValue(nameof(IEntry.CharacterSpacing));
+			handler.UpdateValue(nameof(IEntry.HorizontalTextAlignment));


I'm really new to the MAUI code (I really appreciate all your great work!), but I'm curious why we wouldn't have an handler.UpdateValue(nameof(IEntry.TextColor)); here? I'm curious how these length, spacing and alignment attributes fix the text color (from what I gather, it looks like perhaps we are almost "tricking" iOS into updating the field?). Thank you! 😃

kubaflo · 2024-04-04T23:11:51Z

Also see a very lengthy discussion about this on the live stream here: https://www.youtube.com/watch?v=ERh9Ixz8f_Y

😄

@jfversluis Oh no I missed that stream :/ I rewatched it though, and must admit it was a really good one that hurts me even more that I wasn't there live haha

https://www.youtube.com/watch?v=ERh9Ixz8f_Y&list=LL&index=1

PureWeen · 2024-04-05T21:05:40Z

+
+			// 2. Verify that the Entry bounded TextColor is correct (Green).
+			var color = App.FindElement("").GetText();
+			Assert.AreEqual("[Color: Red=0, Green=0.5019608, Blue=0, Alpha=1]", color);


TextColor won't propagate back up if it's changed unexpectedly on the platform

I think we'll need to test this through screen shot comparisons

That's a good idea

PureWeen · 2024-04-06T15:34:54Z

/azp run

azure-pipelines · 2024-04-06T15:35:13Z

Azure Pipelines successfully started running 3 pipeline(s).

PureWeen · 2024-04-07T04:13:09Z

Can u add the screen shots for all four platforms?

PureWeen · 2024-04-07T17:56:40Z

/azp run

azure-pipelines · 2024-04-07T17:56:59Z

Azure Pipelines successfully started running 3 pipeline(s).

PureWeen · 2024-04-08T13:47:00Z

/azp run

azure-pipelines · 2024-04-08T13:47:21Z

Azure Pipelines successfully started running 3 pipeline(s).

ISSPRO-Eng · 2024-04-08T16:45:36Z

Any updates on when this will be implemented?

ISSPRO-Eng · 2024-04-09T20:43:51Z

How do we utilize this fix using the Nuget Package? Or will there be a release soon

MartyIX · 2024-04-09T21:21:21Z

You can try https://github.com/dotnet/maui/wiki/Nightly-Builds. I check when a nightly build was done and compare it to the moment when a PR was merged.

There was some issue when not every night, there was actually a new build but it should be fixed now. Probably still worth checking the date to be on the safe side.

kubaflo requested a review from a team as a code owner January 23, 2024 10:30

kubaflo requested review from PureWeen and jsuarezruiz January 23, 2024 10:30

ghost added the community ✨ Community Contribution label Jan 23, 2024

kubaflo mentioned this pull request Jan 23, 2024

Entry doesn't use the TextColor property when the Text value is bound after some seconds (iOS) #19509

Closed

jfversluis added platform/ios legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor labels Jan 23, 2024

kubaflo mentioned this pull request Jan 27, 2024

[iOS] [MacCatalyst] Entry Text color not updated initially when updating text from code behind in .NET MAUI #19470

Closed

borrmann mentioned this pull request Jan 29, 2024

Pre-filled Entry ignores TextColor on iOS #20196

Closed

samhouts added the area-controls-entry Entry label Jan 31, 2024

This was referenced Feb 6, 2024

[PM-5906] Fix for incorrect Send MaxAccess white text color on label when using light theme on iOS bitwarden/android#2981

Merged

[PM-5907] Fix for incorrect TOTP white text color on label when using light theme on iOS bitwarden/android#2982

Merged

shawncothran mentioned this pull request Mar 25, 2024

iOS Entry Control Ignores TextColor Property Upon Binding Update #21430

Closed

PureWeen requested changes Mar 28, 2024

View reviewed changes

kubaflo and others added 2 commits March 29, 2024 01:48

Fixed entry text color iOS

836d329

Added UITest

e129eaa

Update Issue19509.xaml

225ebcb

kubaflo force-pushed the entry-text-color-fix branch from 6895f57 to 225ebcb Compare March 29, 2024 01:37

jfversluis reviewed Apr 4, 2024

View reviewed changes

kmoo reviewed Apr 4, 2024

View reviewed changes

kubaflo added 2 commits April 5, 2024 01:40

Updated the UI Text

8f6170d

Improvements from the stream

9925f3a

https://www.youtube.com/watch?v=ERh9Ixz8f_Y&list=LL&index=1

PureWeen requested changes Apr 5, 2024

View reviewed changes

Update Issue19509.cs

b074674

Add screenshot for UI test

5994a3a

Add screenshot for UI test (other platforms)

82ad24c

kubaflo force-pushed the entry-text-color-fix branch from a195a09 to 82ad24c Compare April 8, 2024 10:12

PureWeen approved these changes Apr 8, 2024

View reviewed changes

PureWeen merged commit 998f884 into dotnet:main Apr 8, 2024

jsuarezruiz mentioned this pull request Apr 12, 2024

[Housekeeping] Fix weak UITest #21796

Closed

kramer-e mentioned this pull request May 2, 2024

(iOS) Entrys ignoring textColor-property if text-property set via binding #22025

Closed

github-actions Bot locked and limited conversation to collaborators May 10, 2024

Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024

samhouts added fixed-in-8.0.40 fixed-in-9.0.0-preview.4.10690 labels Aug 2, 2024

Conversation

kubaflo commented Jan 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

Issues Fixed

Uh oh!

ghost commented Jan 23, 2024

Uh oh!

jfversluis commented Jan 23, 2024

Uh oh!

jfversluis commented Jan 23, 2024

Uh oh!

azure-pipelines Bot commented Jan 23, 2024

Uh oh!

jsuarezruiz commented Jan 23, 2024

Uh oh!

kubaflo commented Jan 23, 2024

Uh oh!

jsuarezruiz commented Jan 23, 2024

Uh oh!

jsuarezruiz commented Feb 2, 2024

Uh oh!

azure-pipelines Bot commented Feb 2, 2024

Uh oh!

dartasen commented Mar 21, 2024

Uh oh!

jfversluis commented Mar 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-pipelines Bot commented Mar 22, 2024

Uh oh!

shawncothran commented Mar 25, 2024

Uh oh!

Zack-G-I-T commented Mar 26, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jfversluis left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kubaflo commented Apr 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PureWeen commented Apr 6, 2024

Uh oh!

azure-pipelines Bot commented Apr 6, 2024

Uh oh!

PureWeen commented Apr 7, 2024

Uh oh!

PureWeen commented Apr 7, 2024

Uh oh!

azure-pipelines Bot commented Apr 7, 2024

Uh oh!

PureWeen commented Apr 8, 2024

Uh oh!

azure-pipelines Bot commented Apr 8, 2024

Uh oh!

ISSPRO-Eng commented Apr 8, 2024

Uh oh!

ISSPRO-Eng commented Apr 9, 2024

Uh oh!

MartyIX commented Apr 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

kubaflo commented Jan 23, 2024 •

edited

Loading

jfversluis commented Mar 21, 2024 •

edited

Loading

kubaflo commented Apr 4, 2024 •

edited

Loading

MartyIX commented Apr 9, 2024 •

edited

Loading