Skip to content

Update Template Shell Foreground colour#20152

Merged
PureWeen merged 1 commit intodotnet:mainfrom
licon4812:fix-19178
Mar 18, 2024
Merged

Update Template Shell Foreground colour#20152
PureWeen merged 1 commit intodotnet:mainfrom
licon4812:fix-19178

Conversation

@licon4812
Copy link
Copy Markdown
Contributor

Description of Change

Updated the shell foreground in styles to support Light and dark themes out of the box.

Issues Fixed

Fixes #19178

This PR targets main, although due to it being a tiny 1 line template change, it should be easily backported to older dotnet versions

@licon4812 licon4812 requested a review from a team as a code owner January 25, 2024 06:44
@ghost ghost added the community ✨ Community Contribution label Jan 25, 2024
@ghost
Copy link
Copy Markdown

ghost commented Jan 25, 2024

Hey there @licon4812! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@jsuarezruiz jsuarezruiz added the area-controls-shell Shell Navigation, Routes, Tabs, Flyout label Jan 25, 2024
@davidortinau davidortinau changed the title Updated Shell Foreground colour Update Template Shell Foreground colour Jan 26, 2024
@mattleibow
Copy link
Copy Markdown
Member

Is it possible to revert all the other changes. I was struggling to find the actual change. Thanks!

@licon4812
Copy link
Copy Markdown
Contributor Author

@mattleibow done

Is it possible to revert all the other changes. I was struggling to find the actual change. Thanks!

@PureWeen
Copy link
Copy Markdown
Member

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-shell Shell Navigation, Routes, Tabs, Flyout community ✨ Community Contribution fixed-in-8.0.20 fixed-in-9.0.0-preview.3.10457

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flyout Icon is not displayed on android. Works fine on Windows.

6 participants