[Android] DatePicker Focus and Unfocus events

[kubaflo]

Description of Change

Added DatePicker Focus and Unfocus events

Issues Fixed

Fixes #18797

Demo
Screen.Recording.2024-02-13.at.14.23.34.mov

[ghost]

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

[jsuarezruiz]

If we apply these changes, we should apply them to the TimePicker.

[jsuarezruiz]

Could replicate the same changes in the TimePicker?

[kubaflo]

@jsuarezruiz sure! I've added a commit with this

[jonathanpeppers]

Changes LGTM now. 👍

We should check the new test passed when CI is done.

[jsuarezruiz]

/azp run MAUI-UITests-public

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mos379]

@PureWeen @tj-devel709 how about reviewing this?

[jsuarezruiz]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[pmigliore]

Hi, me and my team are migrating our Xamarin app to MAUI, and we need this feature to move forward, if anyone could take a look at this PR, thanks

[jsuarezruiz]

/azp run

[danbrannanavontus]

Hi - as I understand it this fix hasn't made it into the release due to a merge issue. Would it be possible to get this looked at as this issue is causing a headache for us. Thanks

Dan

[brinawebb]

Hello Maui team. Is there any way this merge can be reviewed/approved? We are trying to convert our mobile project from Xamarin and this issue is preventing us from doing so. Should be a simple approval. Thank you!

[ryanaw83]

This fix is needed... will it be merged soon?

[PureWeen]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[mos379]

@kubaflo nice!

[jsuarezruiz]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[bhavanesh2001]

@PureWeen Just to confirm — based on this #28122 (comment), does this mean the PR won’t be moving forward?

[mattleibow]

@PureWeen Just to confirm — based on this #28122 (comment), does this mean the PR won’t be moving forward?

I think the PRs are different. The other one did this:

PlatformView?.ClearFocus();

It actually changed the focus on the control.

This PR just updates the state in the virtual/xaml view so we get events.

However, this does still mean we need to verify that it does not cause issues. @PureWeen did you have an actual physical keyboard (on the desk) or is there a "virtual physical" keyboard that we can use to test?

[mattleibow]

I am approving this with regards to code and logic and how things "should" work. However, it would be great to get someone with a physical keyboard on their phone to confirm that it does not crash the app or have some focus loops.

[mattleibow]

/rebase

[mattleibow]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[bhavanesh2001]

The control isn’t a true platform input — it's a mix of AppCompatEditText and a dialog. Since nothing is actually focused at the platform level when the dialog is shown, mapping IsFocused to dialog show/dismiss is misleading.

In the case of Picker, a lot of custom wiring was done (like making EditText focusable on touch) just to make focus/unfocus work — which ended up causing subtle bugs: #29068 (comment)

Just wanted to flag this, With #29323 shaping up for .NET 10, might be worth aligning with that direction.

[PureWeen]

pausing based on this comment

#20547 (review)

Do we still need this PR since we are adding APIS in NET10 for opening and closing pickers?

[PureWeen]

Closing this in favor of APIs we're adding into .NET 10
#29323