[Windows] Fix pointer released event not being handled on ImageButton#21766
Merged
Conversation
dotnet-policy-service
Bot
added
the
legacy-area-controls
mattleibow
reviewed
Apr 10, 2024
Contributor
Author
|
If we never had a release event, how did normal/left clicks work???
It uses a “click”, which fires a pressed then released event 😵💫
|
jsuarezruiz
reviewed
Apr 11, 2024
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
added 3 commits
April 26, 2024 09:57
…t/maui into foda/ImgButtonPointerState
jfversluis
reviewed
May 6, 2024
| [Test] | ||
| public async Task ImageButtonStuckAfterRightClick() | ||
| { | ||
| this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Android, TestDevice.Mac, TestDevice.iOS }); |
Member
There was a problem hiding this comment.
Any specific reason we want to not test this on the other platforms?
I get that this is about clicks/hovers so it might not work on some platforms, but if it reasonably can work, why not let them run there as well?
Contributor
Author
There was a problem hiding this comment.
Ah, the ticket mentioned that it already worked fine in macOS, so I wrote the test to only check on Win. The Appium test does specifically use the pointer right click, so we could enable it for macOS as well.
PureWeen
approved these changes
May 7, 2024
tj-devel709
pushed a commit
that referenced
this pull request
May 9, 2024
…#21766) * Fix pointer released event not being handled on ImageButton * Revert bad file include * Actually implement the scripts needed for right click * Fix merge * Remove dupe release event * Update ref image --------- Co-authored-by: Mike Corsaro <mikecorsaro@microsoft.com>
Eilon
removed
the
legacy-area-controls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix pointer released event not being handled on ImageButton, which caused the visual state to not transition when using right click.
Issues Fixed
Fixes #21706