Android: Ensure fragment has not been disposed while updating left bar button#23416
Merged
Conversation
Contributor
|
Hey there @albyrock87! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
albyrock87
force-pushed
the
issue-14801
branch
2 times, most recently
from
8b64f91 to
5184f89
Compare
PureWeen
approved these changes
Jul 3, 2024
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
requested changes
Jul 4, 2024
auto-merge was automatically disabled
July 4, 2024 14:23
Head branch was pushed to by a user without write access
Member
|
/azp run |
PureWeen
approved these changes
Jul 4, 2024
|
Azure Pipelines successfully started running 3 pipeline(s). |
samhouts
added
fixed-in-8.0.70
fixed-in-net9.0-nightly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
UpdateLeftBarButtonItemis anasync void, so it is not being awaited by the navigation.This means that we might have a race condition every time we do
await, because the page might be gone at that time due to an immediate pop navigation.This PR adds a check on the
_isDisposedflag every time we await for something.Issues Fixed
Fixes #14801