Skip to content

[iOS] CarouselView: Changing Position after navigation away then comi…#23477

Merged
rmarinho merged 2 commits into
dotnet:mainfrom
kubaflo:fix-23291
Jul 16, 2024
Merged

[iOS] CarouselView: Changing Position after navigation away then comi…#23477
rmarinho merged 2 commits into
dotnet:mainfrom
kubaflo:fix-23291

Conversation

@kubaflo
Copy link
Copy Markdown
Contributor

@kubaflo kubaflo commented Jul 7, 2024

Issues Fixed

Fixes #23291

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-07-07.at.16.35.20.mp4

@kubaflo kubaflo requested a review from a team as a code owner July 7, 2024 14:37
@kubaflo kubaflo requested review from PureWeen and rmarinho July 7, 2024 14:37
@dotnet-policy-service dotnet-policy-service Bot added the community ✨ Community Contribution label Jul 7, 2024
@kubaflo kubaflo added platform/ios area-controls-collectionview CollectionView, CarouselView, IndicatorView migration-compatibility Xamarin.Forms to .NET MAUI Migration, Upgrade Assistant, Try-Convert labels Jul 7, 2024
@rmarinho
Copy link
Copy Markdown
Member

rmarinho commented Jul 9, 2024

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Copy Markdown
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the test is failing on Windows.

https://dev.azure.com/xamarin/public/_build/results?buildId=118983&view=ms.vss-test-web.build-test-results-tab

@rmarinho
Copy link
Copy Markdown
Member

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Copy Markdown
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed a NRE on windows keeping the test from loading

@kubaflo
Copy link
Copy Markdown
Contributor Author

kubaflo commented Jul 16, 2024

Thanks! @rmarinho

@rmarinho rmarinho merged commit f3c033d into dotnet:main Jul 16, 2024
@samhouts samhouts added fixed-in-net9.0-nightly This may be available in a nightly release! fixed-in-8.0.80 and removed fixed-in-net9.0-nightly This may be available in a nightly release! labels Aug 2, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-collectionview CollectionView, CarouselView, IndicatorView community ✨ Community Contribution fixed-in-8.0.80 fixed-in-net9.0-nightly This may be available in a nightly release! migration-compatibility Xamarin.Forms to .NET MAUI Migration, Upgrade Assistant, Try-Convert platform/ios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CarouselView - iOS - Changing Position no longer works after navigation away then coming back

3 participants