Use UIView.Window instead of the global window#23693
Merged
Merged
Conversation
PureWeen
approved these changes
Jul 18, 2024
rmarinho
approved these changes
Jul 19, 2024
Member
|
/rebase |
github-actions
Bot
force-pushed
the
dev/gm-ios
branch
from
660752e to
32e7703
Compare
pictos
pushed a commit
to pictos/maui
that referenced
this pull request
Jul 22, 2024
[Windows] Fix CollectionView DisconnectHandler SelectionMode Crash (dotnet#23726) * Reorder events to prevent disconnect issues * Add test --------- Co-authored-by: Mike Corsaro <mikecorsaro@microsoft.com> Use UIView.Window instead of the global window (dotnet#23693) [Windows] Subscribe pointer events only when needed (dotnet#23515) Fix iOS log exports (dotnet#23334) * Fix ios Device Logging * - fix up device test logging a bit more * Update ui-tests-steps.yml * Update ui-tests-steps.yml * Update ios.cake * Update ui-tests-steps.yml * Update maui-templates.yml * Update maui-templates.yml remove code from oldFragment add new shiny DialogFragment refactoring code to find and dismiss DialogFragment code cleanup delete ModalContainer to use only ModalFragment handle animation and add a map between page and dialogFragment We've back button enabled! After dismissing several demons summoned using obscure Android APIs, I was able to deal with the BackButtonPressed event add modal animations as anim.xml files using cleanup remowork PopModalPlatformAsync to work with dialogFragment remove tag final adjustments on DialogFragment change the ShowNow for Show to fix the issue Wait for animation to complete change local functions order fix build create window hooks for android (like iOS) clean up ModalFragment fields change Dictionary to ConditionalWeakTable clean up event animation refactor on Null notation remove comments - adjust back button - different back button code style remove unused prop. fix DontPushModalPagesWhenWindowIsDeactivated DeviceTest completes the task return back the way how modalManager handles android modals normilize animation duration Co-authored-by: Shane Neuville <shane94@hotmail.com> remove focusability code change how fragments are looked-up code style
samhouts
added
fixed-in-net9.0-nightly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
I noticed in my embedding world when I did not register the UIWindow with the service collection, this crashed. And then I see we are comparing locations with the Key Window, but not the window that the view is actually on.
Not sure if these decisions were intentional, but the first change to not use the key window just uses the platform view's window and the second is to remove the check that sems to not be used.