Skip to content

[Windows] Fix CarouselView not showing new items#23779

Merged
rmarinho merged 3 commits into
mainfrom
foda/carouseladditem
Aug 6, 2024
Merged

[Windows] Fix CarouselView not showing new items#23779
rmarinho merged 3 commits into
mainfrom
foda/carouseladditem

Conversation

@Foda
Copy link
Copy Markdown
Contributor

@Foda Foda commented Jul 23, 2024

Description of Change

Fix CarouselView not showing new items. This was caused by the inner list of LoopableCollectionView not propagating the VectorChanged event

Issues Fixed

Fixes #17830 #22417

@Foda Foda requested a review from a team as a code owner July 23, 2024 18:16
@Foda Foda requested review from Eilon and jfversluis July 23, 2024 18:16
@Foda Foda added platform/windows area-controls-collectionview CollectionView, CarouselView, IndicatorView labels Jul 23, 2024
Comment thread src/Controls/src/Core/Platform/Windows/CollectionView/LoopableCollectionView.cs Outdated
Add WeakVectorChangedChangedProxy
@rmarinho rmarinho self-requested a review July 26, 2024 11:56
@rmarinho rmarinho requested a review from PureWeen July 30, 2024 16:44
@rmarinho rmarinho merged commit cd7107e into main Aug 6, 2024
@rmarinho rmarinho deleted the foda/carouseladditem branch August 6, 2024 10:56
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Windows] New CarouselView item doesn't render unless Window is resized

4 participants